Gina

Results 21 comments of Gina

@KeithNava You are almost there! Check out [Joy Norms](https://docs.google.com/document/d/1FG9s8Cih9NGbrz7ag4WPLK_W10di-1xfDKy0Fjrg0fM/edit#heading=h.mbg65ucspfbv)- Things to check before creating your pull request- Changelog. Also, the attached guideline document and script in that section is helpful

@KeithNava This _should_ be the [link to your review app](https://review-keithw-lg-jnwu3i.review-app.identitysandbox.gov/)

![Screenshot 2024-04-16 at 8 08 03 AM](https://github.com/18F/identity-idp/assets/125507397/9696465e-05b7-40ec-8eac-e80ee37c287b) ![Screenshot 2024-04-16 at 8 08 14 AM](https://github.com/18F/identity-idp/assets/125507397/ddce20dd-a477-46d6-98de-e2fef88f5b0a) ![Screenshot 2024-04-16 at 8 08 24 AM](https://github.com/18F/identity-idp/assets/125507397/95bd039d-91d0-4eb7-b450-11842bc4c29d)

@KeithNava I do not feel comfortable with the change you pushed up to application.yml. It will turn on our feature flag if this gets merged in without being deleted. I...

@rutvigupta-design There are 8 screenshots in the description above. Let me know what you think. Thank you!

@carmenrosalop I added the margin to the tag. There are screenshots in the description. It is ready for a review. Thank you!

Updated images: **Mobile** Selfie: ![Screenshot 2024-05-13 at 11 35 19 AM](https://github.com/18F/identity-idp/assets/125507397/b465018e-745c-4345-8f78-f7188be0e262) Non-selfie: ![Screenshot 2024-05-13 at 11 36 30 AM](https://github.com/18F/identity-idp/assets/125507397/9ff548ca-4359-485e-a83d-e4c69aff729f) **Desktop** Selfie: ![Screenshot 2024-05-13 at 11 35 37 AM](https://github.com/18F/identity-idp/assets/125507397/87539c90-44d6-417e-a8f1-2f7d51c3deb8) Non-selfie: ![Screenshot...

> Hey @gina-yamada this is looking great. I noticed that I'm seeing some discrepencies from the design on mobile: The Figma design keeps the text wrapped to the right of...

@carmenrosalop Hi Carmen! There are screenshots in the comments section above along with the new ticket. Please have a review and let me know if you approve as is. Thank...

@KeithNava I started to set up the Sinatra app side. I am testing with your branch. Can you add enhanced_ipp_required to the Service Provider session on this branch? I am...