identity-idp icon indicating copy to clipboard operation
identity-idp copied to clipboard
verified publisher icon 18F

feat: updated translations for DOS IPP

Open KeithNava opened this issue 1 year ago • 6 comments

🎫 Ticket

Link to the relevant ticket: LG-13046

🛠 Summary of changes

Translation updates for How to Verify Page

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • [ ] Navigate to the how to verify page
  • [ ] Update language to Spanish
  • [ ] Confirm the content changes are being shown
  • [ ] Update the language to French
  • [ ] Confirm the content changes are being shown
  • [ ] Update the language to Simplified Chinese
  • [ ] Confirm the content changes are being shown

KeithNava avatar Apr 15 '24 12:04 KeithNava

@KeithNava This should be the link to your review app

gina-yamada avatar Apr 15 '24 20:04 gina-yamada

Screenshot 2024-04-16 at 8 08 03 AM

Screenshot 2024-04-16 at 8 08 14 AM

Screenshot 2024-04-16 at 8 08 24 AM

gina-yamada avatar Apr 16 '24 14:04 gina-yamada

@KeithNava I do not feel comfortable with the change you pushed up to application.yml. It will turn on our feature flag if this gets merged in without being deleted. I am going to remove my approval until this get resolved. Please reach out when this is ready to reviewed again

gina-yamada avatar Apr 16 '24 14:04 gina-yamada

The translations content LGTM but I agree with Gina's feedback re: period consistency in the Spanish translation.

  • (H1) Elija cómo desea verificar su identidad – this shouldn't have a period
  • (H2) Verifique su identidad en línea – this shouldn't have a period
  • (H2) Verifique su identidad en una oficina de correos – this shouldn't have a period
  • (button) Continúe en línea – this shouldn't have a period
  • (body copy) Esta opción es mejor si no tiene un teléfono para tomar fotografías de su identificación – this is missing a period

There's also an extra line at the bottom of the help links that I believe shouldn't be there.

Noting that we should not push these changes to prod since we have to get them approved by DOS.

rutvigupta-design avatar Apr 16 '24 14:04 rutvigupta-design

Can you add the Chinese translations for the changes in this PR as well?

@mitchellhenke we did plan on doing the Chinese translations in a separate ticket.

KeithNava avatar Apr 29 '24 20:04 KeithNava

Hi @KeithNava I saw Allison was assigned as a design reviewer for this but since she isn't on the team anymore, I took her off and assigned myself. Please let me know if you need another design review!

rutvigupta-design avatar May 15 '24 22:05 rutvigupta-design

Spanish Translations how_to_verify_DOS_es_translation_5_20_24 French Translations how_to_verify_DOS_fr_translation_5_20_24 Simplified Chinese Translations how_to_verify_DOS_simplified_chinese_translation_5_20_24

@rutvigupta-design

KeithNava avatar May 20 '24 18:05 KeithNava

@rutvigupta-design Thanks for the review - looks like I had a bad merge conflict. Here's the updated screenshot for the Spanish translations. how_to_verify_DOS_es_translation_5_20_24_2

KeithNava avatar May 20 '24 20:05 KeithNava

@mitchellhenke @gina-yamada I think the merge is awaiting your approval. Thanks!

KeithNava avatar May 21 '24 14:05 KeithNava

@rutvigupta-design @gina-yamada Latest screenshots are below

Spanish Translations how_to_verify_DOS_es_translation_5_21_24

French Translations how_to_verify_DOS_fr_translation_5_21_24

Simplified Chinese Translations how_to_verify_DOS_simplified_chinese_translation_5_21_24

KeithNava avatar May 21 '24 19:05 KeithNava

@KeithNava latest screenshots look great to me! 🎉

rutvigupta-design avatar May 21 '24 19:05 rutvigupta-design