Garrett Honeycutt

Results 20 comments of Garrett Honeycutt

This seems a little complex, suggest adding an example to the README.

Adding an acceptance test would make more casual users of this module feel better about pressing the merge button :)

This approach looks sane to me. The content should be in a template file though. This allows it to be validated, makes it easier to read, and gets around quoting...

@LukasAud Could you please take a look at this one. It is similar in nature to the one you just merged.

It is removing more cruft :) @alexjfisher Check out the ticket for more info. Basically backups are too specialized to the user's environment so an example would be better than...

@jblom Could you submit a pull request for the README update? That will certainly help others in the future avoid having to figure this out again.

+1 though I think it should be optional and default to false since it is both new and still experimental.