puppet-jenkins Add spec tests for jenkins::slave::tunnel parameter

Add spec tests for jenkins::slave::tunnel parameter

Open ghoneycutt opened this issue 6 years ago • 10 comments

Feb 08 '18 19:02 ghoneycutt

Adds on to #840

Feb 08 '18 19:02 ghoneycutt

@ghoneycutt Do you mean https://github.com/voxpupuli/puppet-jenkins/pull/840 ?

Feb 08 '18 19:02 alexjfisher

@alexjfisher yes, thanks!

Feb 08 '18 19:02 ghoneycutt

@ghoneycutt Would you mind if https://github.com/voxpupuli/puppet-jenkins/pull/843 went in first and then rebasing and checking the rubocop violations that PR fixed haven't been reintroduced?

Feb 08 '18 19:02 alexjfisher

It needs to be rebased to be a FF merge anyways.

Feb 08 '18 21:02 jhoblitt

@jhoblitt Would you prefer all merges to be fast-forward only? I think this can be configured (we don't usually enforce that, but I think we could trial it on this project if you wanted).

Feb 09 '18 19:02 alexjfisher

@alexjfisher I've never been a stickler about requiring general PRs to be a FF merge, although, I always ensure that my PRs are.

Feb 12 '18 16:02 jhoblitt

@ghoneycutt Could you rebase?

Feb 12 '18 16:02 jhoblitt

Dear @ghoneycutt, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks