puppet-jenkins
puppet-jenkins copied to clipboard
Add spec tests for jenkins::slave::tunnel parameter
Adds on to #840
@ghoneycutt Do you mean https://github.com/voxpupuli/puppet-jenkins/pull/840 ?
@alexjfisher yes, thanks!
@ghoneycutt Would you mind if https://github.com/voxpupuli/puppet-jenkins/pull/843 went in first and then rebasing and checking the rubocop violations that PR fixed haven't been reintroduced?
It needs to be rebased to be a FF merge anyways.
@jhoblitt Would you prefer all merges to be fast-forward only? I think this can be configured (we don't usually enforce that, but I think we could trial it on this project if you wanted).
@alexjfisher I've never been a stickler about requiring general PRs to be a FF merge, although, I always ensure that my PRs are.
@ghoneycutt Could you rebase?
Dear @ghoneycutt, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @ghoneycutt, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Closing for inactivity.