Gabby Getz
Gabby Getz
Thanks @pmconne and @markschlosseratbentley! This looks ready to go. We'll follow up in https://github.com/CesiumGS/cesium/issues/5214 for additional updates.
Thanks @jjhembd! - Do you have any thoughts on what using `czm_globeDepthTexture` would mean for precision and accuracy? - For axes other than directly along the current camera ray, is...
Looks like this was resolved by https://github.com/CesiumGS/cesium/pull/12636. I'm going to go ahead and close, but @jjhembd please feel free to reopen if I missed anything.
Rather than putting this in the coding guide, this should be enforced through eslint: https://eslint.org/docs/latest/rules/prefer-destructuring
Are there any performance implications to using destructuring assignment everwhere?
@ebogo1 I'm not seeing any test failures in Chrome on Mac OS as of testing for the 1.90 release. Are you still seeing any?
I've been seeing this often in CI. Maybe as a quick fix, we could pass through a higher `timeout` value through `Cesium3DTilesTester.waitForTilesLoaded` to `pollToPromise`.
It's been a while, but this one just popped back up for me in CI: ``` Scene/Cesium3DTileset ✗ Restrict tileset memory usage with maximumCacheOverflowBytes Error: Timeout - function did not...
> This is the same functions with a modifier of 0.4. As you can see the fog (purple) much closer matches reaching 1 around the same time the red fog...
> I did just notice our fog seems inconsistently applied as we zoom in and out and very close to the ground it's not applied at all which I think...