Hao Wu
Hao Wu
Effect of Unknown in WHERE clauses. See https://en.wikipedia.org/wiki/Null_(SQL)
> Do we have the same problem in `setupUDPListeningSocket()`? > > By the way, what exactly is the problem here? Is it a transient problem, does the error stop occurring...
@Nirali13 Maybe we need a tool to dig out all these references, so the exceptions can be reported.
Sounds reasonable, I'll take some time to update the PR.
@soumyadeep2007 Just a reminder, the PR hits some conflicts.
It looks cool. I'll test this patch with pg_auto_failover.
@asimrp The pg_control_version written in the control file isn't changed, right? pg_auto_failover has a function `pgsql_get_postgres_metadata()` that directly calls the UDF `pg_control_system()` to get the pg_control_version. The `pg_control_version` looks un-converted....
A minimal change I come up with in pg_auto_failover is: ```diff diff --git a/src/bin/pg_autoctl/parsing.c b/src/bin/pg_autoctl/parsing.c index 6ff04e1..4772bc6 100644 --- a/src/bin/pg_autoctl/parsing.c +++ b/src/bin/pg_autoctl/parsing.c @@ -154,6 +154,8 @@ parse_controldata(PostgresControlData *pgControlData, log_error("Failed to...
> I'm wondering if we could revert the gp change against PG_CONTROL_VERSION instead. I do not see any need of adding the gp version in PG_CONTROL_VERSION now, presuming that we...
> I had tried reverting `PG_CONTROL_VERSION` macro to upstream version and having a separate `GP_CONTROL_VERSION`. That patch seemed a lot more intrusive that the current proposal. If you guys feel...