gpdb icon indicating copy to clipboard operation
gpdb copied to clipboard

Refactor interconnect structs ChunkTransportState{Entry}

Open soumyadeep2007 opened this issue 5 years ago • 4 comments

We noticed that there were a lot of fields in the structs ChunkTransportState and ChunkTransportStateEntry that were only used by a specific interconnect type. So, we sought to specialize the structs to fit the interconnect type, pushing interconnect-specific fields to sub-structs.

Co-authored-by: Soumyadeep Chakraborty [email protected]

soumyadeep2007 avatar May 01 '20 05:05 soumyadeep2007

This is ready for review. Refactoring the MotionConn can be done as a separate PR.

soumyadeep2007 avatar May 07 '20 23:05 soumyadeep2007

@soumyadeep2007 Just a reminder, the PR hits some conflicts.

gfphoenix78 avatar Feb 05 '21 02:02 gfphoenix78

@soumyadeep2007 what's your take on this PR, still something we should commit? wish to bring it to commit state? abandon and close it out? or keep it around for some more time just to see?

ashwinstar avatar Oct 29 '21 23:10 ashwinstar

This has rotted quite a bit and I imagine there were changes made when introducing IC proxy. But I think it is valuable and I can attempt to bring it to a committable state.

soumyadeep2007 avatar Oct 30 '21 00:10 soumyadeep2007

Closing for now. Will revisit in the future, when I have cycles.

soumyadeep2007 avatar Oct 26 '22 16:10 soumyadeep2007