Dave Smith
Dave Smith
@richtabor do we still want to pursue this?
@richtabor Worth noting that [recent a11y review of this control](https://github.com/WordPress/gutenberg/pull/54063#issuecomment-1708852218) suggested that perhaps the preview step isn't that helpful > Figure out how to make the link preview popover feel...
Marking this as ready for initial review. Obviously if we proceed with this route then the tests will need updating - assume I will handle that. Other specific points of...
> I find it a bit jarring that the control closes @scruffian Can you explain what you meant by this? - Do you mean when creating a link or when...
Ah yes @alexstine I'm sorry. I totally missed the obvious problem that using focus on mount on moving into the link was going to cause a11y issues. I should be...
> Would be interesting to explore leaving it open in another PR though! Maybe it's already been done? @richtabor @jeryj Am I missing something here or would keeping the modal...
Whilst I recognise the flows proposed above, the interaction to have the control appear as soon as you enter a link format has been established in the editor for some...
> If the opinion now is we can't really fix it because users expect it to operate this way, not sure how to move this PR forward I'm not saying...
This component has existed in Gutenberg for a long time as experimental. However in many ways it could be considered a public API because it's been adopted and used by...
I think given it's been around for so long it's pretty much defacto stable anyway. We should formalise that. The last 2 releases saw a lot of UX work going...