Dave Smith
Dave Smith
Firstly thanks for raising this @paaljoachim. Much appreciated. > I recalled we agreed on having filter/hook on the link control for developers to extend; and be able to add these...
My view is that Gutenberg should offer a sensible set of common default settings. Would this suffice? - Open in new tab - No follow - CSS classes
I rebased here because my recent changes to the UX in Core weren't reflected but it seems I made a mistake and reverted @jeryj's progress. He will have his local...
> What's left here to get this merged? More reviews and testing I believe.
I guess another option is to remove the `ul > li` markup entirely _in the editor_ (only) and just use `div > buttons`. I know that we've established that markup...
That's super helpful detail @afercia 👍
@fabiankaegy Yes it does: - https://github.com/WordPress/gutenberg/blob/df27bd934838d56271224c76d54402886b88160c/packages/block-editor/src/store/selectors.js#L2972-L2977 - https://github.com/WordPress/gutenberg/blob/df27bd934838d56271224c76d54402886b88160c/packages/block-editor/src/store/selectors.js#L2996-L3000
Just noting that this was proposed in https://github.com/WordPress/gutenberg/issues/51737#issuecomment-1934033369 but didn't make it into 6.5. Has the consensus changed?
> #51737 (comment) I can't add much more than what's conveyed in that comment. It boils down to: > ...there is an established convention in the editor that pressing Cmd...
@kevin940726 @ndiego @colorful-tones Shall we pursue this for 6.7? If so then we'll need a backport PR as per the failing check below.