Dave Smith
Dave Smith
@madrobby Just checking in to see whether this ever got merged. Don't think so from the look of things.
Please see https://github.com/WordPress/gutenberg/issues/41146#issuecomment-1172231277. Also a patch fix has landed in https://github.com/WordPress/gutenberg/pull/44578.
Hope you don't mind I updated the title and desc to include that you might also consider implementing `:focus` just for a11y reasons 🙇
> A technical review was done by @getdave, as well as, @draganescu and @scruffian whilst the course was created. Just to note that I haven't performed any review on the...
@draganescu Just confirming that this _won't_ now make it into 6.1 right?
Noting that the Nav block currently specifies `4` as the fallback https://github.com/WordPress/gutenberg/blob/42874766e492aacdee1fb73dd94dd7938acbf2a9/packages/block-library/src/navigation/index.php#L311
I've had a think about this overnight. I'm asking myself how many users will actually have this many top level pages? Answer is very few. Let's optimise for the 80%...
OK folks I [raised a PR that will remove the max limit attribute from the Page list block](https://github.com/WordPress/gutenberg/pull/44415). Please take a look and let me know if we're happy to...
We could make the overlay a separate block with its own inner blocks which can include the Nav block _and_ other types of blocks.
My main question is how do you configure the overlay block and the Nav block to show/hide depending on viewport size? I guess for now using some rudimentary "Mobile" toggle...