George Zubrienko

Results 85 comments of George Zubrienko

Will take a look soon, sorry bit slow on our side here. Tough times.

Apparently this is how python converts a compatible collection into tuples (3.11): ``` > tuple(["a", "b"]) ('a', 'b') > tuple([["a", "b"], "b"]) (['a', 'b'], 'b') ``` So the library in...

It is because DCJ relies on outer type only. So when you have coherent types inside (only tuples), it will work fine. But when there is a variation - stuff...

Yeah I agree. Re v1, it has not been forgotten, I have one major contrib I need to make within other OSS project and then I will have time to...

I think there are several things we should definitely do: - Remove 3.6 where it is still mentioned - Remove 3.7 from unit test matrix, but allow installation on 3.7...

> Does the documentation build automatically for the PR CI triggers? That's the fun part, I do not actually know what builds GH pages 😄 , we only have access...

Great questions, my thoughts below > I have some technical questions here. > > 1. Which versions of Python should we support? I'm in favour of hard-locking v1 API in...

@lidatong there is a chance this can be fixed by this https://github.com/MishaKav/pytest-coverage-comment/issues/68#issuecomment-1469626721 - could you test? I honestly do not remember what fixed this in our OSS repos for forks,...

as an alternative, I can disable coverage comment with either `hide-comment` or by disabling the step with ``` if: ${{ !github.event.pull_request.head.repo.fork }} ```