George Zubrienko

Results 85 comments of George Zubrienko

@lidatong @s-vitaliy @matt035343 @healthmatrice @artificial-aidan and many others please let us know your thoughts on this one :)

Updated to make code look more like its actual python and not Java lol. Re how we will, if agreed, do this - by creating a new "release" v1 branch...

> I probably will hate the metaclass implementation. I used to use lots of metaclasses in one of my project. But in the end we almost ditched all the metaclasses...

> frameworks, and since there's no way for pip to provide different versions for each of them, if any of them wants to update, every other one should update Poetry...

> de)serializer (similarly to how DCs constructor work) and use those instead of relying on the meta fields. I tend to get rid of annotation usage all together to be...

> Imagine this code: > > ``` > from dataclasses_json import settings > from dataclasses_json import JsonSerializer > > settings.enable_optimizations() > JsonSerializer[DataPerson].to_json(d_person) > ``` > > Which internally checks if...

> How would you achieve such behavior? Usually generics won't provide their own type variables (unless `typing` has changed how it works) You can check for the actual type provided...

> is there any plan to support discriminator? https://github.com/Fatal1ty/mashumaro#discriminator-config-option I don't think we will need that at all with the new API. As I mentioned, class hierarchies should be ser-desered...

Hey thanks for kind words, I do believe something good will come out of this :) Re `from_json[T](...)` would be nice but python doesn't allow generics on methods this way,...

Looks great, I'll have a more thorough look later this week. Re metaclasses, I think given the concerns expressed about them, maybe we should consider that as a last resort...