dataclasses-json icon indicating copy to clipboard operation
dataclasses-json copied to clipboard

Published 20 hours ago • verified publisher icon lidatong

Code Coverage Publish breaks CI on Fork PRs

Open george-zubrienko opened this issue 2 years ago • 2 comments

Apparently GH Actions do not allow fork PR runs to post comments on parent repo. We should skip coverage publishing for forks as a quick workaround

https://github.com/community/community/discussions/25217#discussioncomment-3246902

george-zubrienko avatar Jul 20 '23 22:07 george-zubrienko

@lidatong there is a chance this can be fixed by this https://github.com/MishaKav/pytest-coverage-comment/issues/68#issuecomment-1469626721 - could you test? I honestly do not remember what fixed this in our OSS repos for forks, or if we ever fixed that at all

george-zubrienko avatar Jul 21 '23 18:07 george-zubrienko

as an alternative, I can disable coverage comment with either hide-comment or by disabling the step with

if: ${{ !github.event.pull_request.head.repo.fork }}

george-zubrienko avatar Jul 21 '23 18:07 george-zubrienko