George Knee
George Knee
These were temporarily removed in #236. To reinsert, we need to ensure the CI checks pass (in particular the genesis hash check). We should be able to get the config...
> I would prefer to make this change in op-node, where it can differentiate based on the new superchain level. The rationale being that I think we ultimately want to...
It looks like the superchain targets are hard coded into that test https://github.com/security-alliance/superchain-registry/blob/f14dc47551fdc4a5b48548a1b5bc8530d74f8ecd/scripts/CheckSecurityConfigs.s.sol#L47-L59 . To bring the test in line with the other tests in the repo, it should loop...
For instance, such chains do not have an L2OutputOracle. From @mds1 in slack: > I think in the [standard config] toml we can have the values for both L2OO and...
`finalizationPeriodSeconds` on Sepolia is an obvious place to look next. I suspect being strict about `12` is not what we want to do. _Originally posted by @geoknee in https://github.com/ethereum-optimism/superchain-registry/pull/208#discussion_r1580090585_ We...
once https://github.com/ethereum-optimism/specs/pull/134 is merged, we should revisit this file to ensure everything matches _Originally posted by @mds1 in https://github.com/ethereum-optimism/superchain-registry/pull/188#discussion_r1569445625_
* update the contributing guide * allow both sets of tests to be run against a single chain or all chains with a single command (perhaps using `make`).
Closes https://github.com/ethereum-optimism/client-pod/issues/847 Test currently failing due to name mismatches. It is likely and acceptable for a chain to already exist at chainId.network, so we need a way of checking whether...
Here's where that constraint comes from: https://github.com/ethereum-optimism/superchain-registry/blob/730d61f58c4b107f96e65959d6a1895b5c48b60b/scripts/add-chain.sh#L59-L61 I think we _either_: 1. Allow the filename to be set by a new, separate environment variable 2. (My preference) Use the incoming...