George Knee

Results 143 issues of George Knee

For understanding: this is meant to be sparse? A filecoin provider will expect to have a fair number of channels running with lots of micro-transactions in each. _Originally posted by...

From the [grant proposal: ](https://github.com/filecoin-project/devgrants/issues/1508) **Challenge module** In the current version of go-nitro peer inactivity is not detected and results in funds being locked in a channel. We will fix...

From the [grant proposal: ](https://github.com/filecoin-project/devgrants/issues/1508) The on-chain challenge method (and associated go-nitro module in Milestone 3) gives power to participants to “take each other to court”. This is an important...

Based off of the optimisations done in #106

We can use GO's benchmark system. We may need a stress test which runs for a decent amount of time. We are currently writing every second. We can experiment with...

🐎 performance

From the grant proposal: > Documentation explaining configuration of this new store, including a discussion of risk / performance tradeoffs . For example, writing some data to the store less...

📖 documentation

This doesn't align with best practices around handling private keys: https://github.com/statechannels/go-nitro/blob/92d6f4d92c4e567181216a0517b631e7f6f65e05/client/engine/messageservice/p2p-message-service/service.go#L76 See https://www.notion.so/statechannels/RFC-8-Securing-Private-StateChannel-Key-c4f2945172d84db2b84220d64502e38c for details. Apparently the motivation was to create a deterministic message key from the channel signing key....

🔒 security

Right now, anyone can spend money or otherwise cause havoc via a nitro node's public RPC endpoint.

:building_construction: Productionization

## Context Currently, `go-nitro` accepts a `chainPk` (chain private key) through its [CLI entrypoint](https://github.com/statechannels/go-nitro/blob/e3901151c5ecd773359a1a89b72ce338efa69459/main.go#L86). This is [used to construct an `EthChainService`](https://github.com/statechannels/go-nitro/blob/2b0bc7c5998abe021970704f448d030844a05928/node/engine/chainservice/eth_chainservice.go#L67) which is (in turn) injected into the [`node` constructor.](https://github.com/statechannels/go-nitro/blob/2b0bc7c5998abe021970704f448d030844a05928/node/node.go#L52)....

yellow

At this time, `go-nitro` supports: * directly funded ledger channels and * virtually funded payment channels. The broader nitro-protocol supports arbitrary 3rd party applications https://docs.statechannels.org/protocol-tutorial/0020-execution-rules/#application-rules. Proposed Changes: 1. API changes...

✨ enhancement
yellow