George Knee
George Knee
https://github.com/statechannels/go-nitro/actions/runs/6014659940/job/16314869807
Currently, we spin up a number of rpc servers, and use the `client-runner` ts-node script to drive them. A better solution would be to write a jest test to replace...
In our github action, the client runner waits 120 seconds or more for the rpc servers. but the logs show that they should be ready after about 10-15 seconds. so...
Ideally we wouldn't have to hardcode the units into the payment proxy error. Maybe it could return a JSON error that we could parse out in the client? _Originally posted...
Might be worthwhile guarding against the other headers already being set. _Originally posted by @lalexgap in https://github.com/statechannels/go-nitro/pull/1782#discussion_r1333285771_
This actually causes the nitro node to crash, which is something we should look into separately: ``` {"time":"2023-09-13T06:31:49.184521+01:00","level":"INFO","msg":"handling new objective request","address":"0xAAA6628Ec44A8a742987EF3A114dDFE2D4F7aDCE","objective-id":"VirtualFund-0x8f3291c17c49760237b5ba51f92d96c3e1c51bc925f3cb7252172ef9f5eee549"} panic: runtime error: invalid memory address or nil pointer...
> This LGTM, but wanting for a follow-up with tests that consume the same. I added a test here [add estUpdateWithChallengeRegisteredEvent](https://github.com/statechannels/go-nitro/pull/1593/commits/f68bdd7c87ceb7277e193661479c54f935dae814) but as you say it doesn't cover that much...
From the[ grant proposal:](https://github.com/filecoin-project/devgrants/issues/1508) Even with a durable store, it is possible for clients to become “out of sync”. In this context, that means that go-nitro peers are still online,...
We need to audit: on chain events (does Concluded give sufficient information to subsequently call transfer? Does Challenge need to be so verbose / heavy?) extent to which we rely...