George Antoniadis
George Antoniadis
+1 for multiline function definitions and calls. I understand that you don't like options, I assume that includes different versions of the tool? Maybe something behind a build tag and...
@mvdan I apologize, I should have explained better. I was just suggesting a different way to do configuration. I understand you probably are not interested in this either but I...
This is awesome @mvdan thank you :D ❤️ I'll post this here so not to pollute the PR with discussions. Is the way func definitions and calls are split final?...
@mvdan that makes sense thank you for the explanation. --- My main concern with the conservative approach is the merging of small lines into things that (imo) are much less...
@mvdan erm. o_O Do you mind running this test? https://github.com/mvdan/gofumpt/compare/break-long-lines...geoah:break-long-lines I get a failure with ``` -var AccountRequestsDefaultPermissionsMessy = []string{ - "ReadAccountsDetail", "ReadBalances", - "ReadBeneficiariesDetail", "ReadDirectDebits", "ReadProducts", "ReadStandingOrdersDetail", - "ReadTransactionsCredits",...
asdf. - ^ this also exists in the master gofumpt. sorry for this. :( in master ```go var ( AccountRequestsDefaultPermissions = []string{ "ReadAccountsDetail", "ReadBalances", "ReadBeneficiariesDetail", "ReadDirectDebits", "ReadProducts", "ReadStandingOrdersDetail", "ReadTransactionsCredits", "ReadTransactionsDebits",...
Sigh. go1.14 is officially out (yay), and `checkptr` validation is now a real thing :D ~@calmh thank you for taking the time to work on this, I stole your test...
Hey @dominikbraun, thank you for your reply and answering my questions. Do you think splitting out the store interface would be of use to this library or would it be...
That's really nice to hear. :D 1. I struggled with this a bit and the issue I had was that in order for me to add a `Store[K, T]` in...
Hey @dominikbraun, quick update. 1. Effing generics... I noticed that we don't really need the hashing function in the store so did some refactoring to remove it, but even then,...