Guillaume E
Guillaume E
This is a test for the behavior in #169. This pull request can be removed and #169 marked as fixed once the GitHub checks fail here. - [ ] Tests...
The [cargo-outdated](https://github.com/kbknapp/cargo-outdated) tool checks for outdated dependencies in a Cargo.toml. As a complement to cargo-audit which checks for vulnerable dependencies, we should leverage that to make sure dependencies are up-to-date.
As pointed out in https://github.com/google/OpenSK/pull/165#discussion_r499035911, we currently allow comments that exceed the maximum line length normally allowed by Rustfmt. We could enable the [`wrap_comments` option](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#wrap_comments) in `rustfmt.toml` to make sure...
We should have a CI pass that checks that our patches on top of Tock are properly formatted. We could run `cargo fmt --check` on `third_party/tock/` after the patches being...
## Expected Behavior GitHub workflows do only the necessary amount of work and complete as fast as possible. ## Actual Behavior Most of our workflows run `./setup.sh`, which compiles and...
## Expected Behavior When Clippy warns against a lint with `-D warnings` in a GitHub workflow, the lint is reported and the workflow fails. ## Actual Behavior On the pull...
It seems that Clippy checks code only for a specific set of features. In #162, we added support for Clippy with `--features std`, we should also test other features, similarly...
The top-level package is both a library `src/lib.rs` and a binary `src/main.rs`. This creates quite a bit of confusion, as highlighted in #149 and #156, and may cause increased binary...
Having the `nrf52840_dongle_dfu` and `nrf52840_mdk_dfu` boards upstreamed to mainline Tock would avoid us having to maintain them here, and would benefit users of these boards for use cases beyond OpenSK.
## Expected Behavior Cargo audit doesn't find any advisory. ## Actual Behavior [RUSTSEC-2019-0031](https://rustsec.org/advisories/RUSTSEC-2019-0031) is found. ``` Crate: spin Title: spin is no longer actively maintained Date: 2019-11-21 URL: https://rustsec.org/advisories/RUSTSEC-2019-0031 Dependency...