OpenSK icon indicating copy to clipboard operation
OpenSK copied to clipboard

Published 20 hours ago • verified publisher icon google

[Do not merge] Test pull-request for issue #169.

Open gendx opened this issue 3 years ago • 5 comments

This is a test for the behavior in #169. This pull request can be removed and #169 marked as fixed once the GitHub checks fail here.

  • [ ] Tests pass
  • [ ] Appropriate changes to README are included in PR

gendx avatar Sep 29 '20 13:09 gendx

@gendx Is this still uesful to be kept open as a canary?

kaczmarczyck avatar Sep 09 '21 05:09 kaczmarczyck

@gendx Is this still uesful to be kept open as a canary?

Just rebased this pull request to see if the Clippy workflow now fails.

gendx avatar Sep 13 '21 08:09 gendx

Coverage Status

Coverage remained the same at 41.891% when pulling 951a310ae170e9103a4f4aa047c69169da09eff4 on gendx:issue-169 into c1f2551d0d246c4170079140c1196d1689a0ce7a on google:develop.

coveralls avatar Sep 13 '21 08:09 coveralls

Anyway, due to recent changes on Github, the workflow for Clippy must be adjusted for it to work properly. It now must be split into 2 workflows: an untrusted one which analyses the PR and produces a structured file with the results and a trusted one which takes this file and creates the annotations.

jmichelp avatar Sep 13 '21 08:09 jmichelp

Looks like the current workflow passed instead of denying the lint, so leaving this PR open until #169 is fixed.

gendx avatar Sep 13 '21 08:09 gendx

This PR does not work with the current CI, since crypto was excluded from clippy. I verified that CI fails when I add a let-and-return in the opensk library.

kaczmarczyck avatar Nov 09 '23 14:11 kaczmarczyck