Geoffrey Biggs

Results 149 comments of Geoffrey Biggs

I think merging it while the asan and tsan tests don't pass is OK, but I agree with the need to have it running from CI.

* Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17851)](http://ci.ros2.org/job/ci_linux/17851/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=12419)](http://ci.ros2.org/job/ci_linux-aarch64/12419/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=18519)](http://ci.ros2.org/job/ci_windows/18519/)

Sure! Thanks for checking.

One way to do it would be to use `colcon` in a workspace containing the ROS 2 source checked out from `ros2.repos`: ``` colcon build --event-handlers console_package_list+ --packages-above class_loader ```...

@tylerjw There are a couple of points that need addressing before this can be merged. 1. Since this is a significant API change, we should do a tick-tock. This means...

Is this PR still necessary after #201?

Can you please re-target this PR to the `noetic-devel` branch? We should merge it there first and then backport to Melodic.

Thanks for the reminder. I've just done a Foxy release, so it will be in the next sync.

Because ROS Noetic targets Python 3.8, and there are no future planned releases of ROS 1, I think it's unlikely that anyone will put in the effort to fix this....

Since ROS 2 uses C++11, I think that explicitly typing the enums seems like the best option if MISRA accepts that. (I haven't read MISRA in a few years, and...