Gonzalo Balabasquer

Results 41 comments of Gonzalo Balabasquer

@kumavis sorry to tag you, but could someone look at this issue, please. It's impossible to interact with MKR at the moment using Metamask and it has been broken for...

> Update: the fix for this has been merged, but it depends on this other issue that have yet to be merged: #14906 Do you think it will be merged...

the require happens before the `delegatecall` https://github.com/dapphub/ds-proxy/blob/master/src/proxy.sol#L60 But if the call fails, should also revert. Which is the exact example you are trying and what is the result?

@nmushegian if you want to transfer ETH to a key from your proxy, you would need to `delegatecall` to a contract that does that. I can imagine something like: ```...

@rainbreak what do you think about this change? apparently if you delegatecall to an address that doesn't have code it doesn't revert, just passes. I'm not sure if that is...

> With constantinople you can also consider `extcodehash` Yeah, I was planning to take care of it in another PR.

ahh @rainbreak you were meaning for this specific check, I thought you were talking about the possibility of simplifying the cache with the new opcode. Anyway I think using `extcodesize`...

@rainbreak can we merge this?

> > > With constantinople you can also consider `extcodehash` > > > > > > Yeah, I was planning to take care of it in another PR. > >...