[Bug]: Error: Unable to determine contract standard in non-standard (MKR) token

[brianmcmichael]

Describe the bug

User reported they couldn't send MKR token via Metamask. I've confirmed.

When trying to send MKR via the extension the UI halts with the loading icon and the consol prints "Error: Unable to determine contract standard"

MKR token is non-standard so some custom logic will likely need to be drawn up around it, the non-standard features are:

• name returns bytes32 (instead of string)
• symbol returns bytes32 (instead of string)
• decimals returns uint256 (instead of uint8)

Note that these idiosyncrasies are not exclusive to MKR, and will be present in any ds-token derived token deployed prior to 2021.

Steps to reproduce

1. Have MKR in wallet
2. Try to send MKR via metamask extension

Error messages or log output

Uncaught (in promise) Error: Unable to determine contract standard
  at f.<anonymous> (common-1.js:7:379146)
  at Generator.throw (<anonymous>)
  at a (common-1.js:7:376936)

### Version

10.11.3

### Build type

_No response_

### Browser

Chrome

### Operating system

Linux

### Hardware wallet

_No response_

### Additional context

_No response_

[wajeshubham]

I am getting same error after trying to transfer my own ERC20 token through Ropsten Test Network.

[nathgilson]

Same with Goerli test net

[hdany]

I confirm I have the same problem. I openned a thread on Metamask community. This used to work perfectly on 10.11.3 (about a month ago), so it's a new introduced bug. Looking forward for a fix

[kdumovic]

Happening to me too interacting with the DGD ERC20 contract

Affecting 10.13.0

[PascalDuval]

Same problem

[chinu-dev]

We have method approve with same signature on vault contract, worked before and we need user to approve the spender contract first. Cannot workaround without downgrading metamask.

Can it be written more defensively?

[gbalabasquer]

@kumavis sorry to tag you, but could someone look at this issue, please. It's impossible to interact with MKR at the moment using Metamask and it has been broken for some quite time. Thanks.

[sloppycoffee]

Have this same issue on rinkeby trying to approve an erc20

[NinjaTurtle007]

I confirm this problem and here are more people having it with some more info https://community.metamask.io/t/i-cant-send-just-the-mkr-token/19753/15

[FrederikBolding]

Thanks for reporting everyone! Fix underway here: https://github.com/MetaMask/controllers/pull/830

[bschorchit]

Closing this as the fix has been merged. This should be fixed for users in one of our next releases.

[Sofianel5]

I'm still having this issue with the Ethernaut Dex challenge

[NinjaTurtle007]

me too, this has been closed with fix coming in next release 29 days ago, but still can't do anything with MKR token.

[NinjaTurtle007]

Any ETA on when we will be able to send our MKR tokens? :)

[MayasHaddad]

Still facing the issue on version 10.15.1

[NinjaTurtle007]

Yes still can't interact with MKR tokens I confirm. Also feels like this issue has been abandoned, anyone?

[bschorchit]

Update: the fix for this has been merged, but it depends on this other issue that have yet to be merged: https://github.com/MetaMask/metamask-extension/pull/14906

[gbalabasquer]

Update: the fix for this has been merged, but it depends on this other issue that have yet to be merged: #14906

Do you think it will be merged and release soon? We are talking about Maker token, OG project, and old friend of Metamask. It has been broken for several months causing several issues to our users. Can this be escalated and fixed soon?

[bschorchit]

Update: this will be fixed in extension release v10.19

[NinjaTurtle007]

Update: this will be fixed in extension release v10.19

when will this be released?

[fepvenancio]

If you declare a variable:

uint8 public decimals;

And on the constructor set it to 0:

decimals = 0;

it will work as mentioned in the standards.

[kevinghim]

The fix will be released with 10.19.0 which will start rolling out late next week.

[jaywuzer]

Alright, when will this finally be rolled out? My MKR has been stuck in my MetaMask long enough and I am trying to exit tf out already lol

[Bultik41]

ср, 10 серп. 2022, 05:46 користувач JayWuzer @.***> пише:

Alright, when will this finally be rolled out? My MKR has been stuck in my MetaMask long enough and I am trying to exit tf out already lol

— Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/14187#issuecomment-1210086782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX5ACNIBWZZFR5D6ZCD2P6DVYMJXXANCNFSM5RRR3N5A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[NinjaTurtle007]

Alright, when will this finally be rolled out? My MKR has been stuck in my MetaMask long enough and I am trying to exit tf out already lol

I'm wondering the same thing.

[jaywuzer]

Hello...? I'd like to know when I can finally move my MKR out. It has been a really long time lol

[NinjaTurtle007]

yes we were told it should be a week ago......

[jaywuzer]

Bruh.

[jaywuzer]

I'm pissed lol

[jaywuzer]

Bruh it has been damn near two weeks since I first came here to drop a comment. What're y'all doing lol