Gavin King

Results 238 comments of Gavin King

@beikov please also consider what happens with the following code: ```java var query = factory.getCriteriaBuilder().createQuery(String[].class); var bookRoot = query.from(Book.class); query.multiselect(bookRoot.get("isbn"), bookRoot.get("title"), bookRoot.get("pages")); var resultList = entityManager.createQuery(query).getResultList(); ``` This should throw...

A second item of feedback is: even the javadoc of `multiselect()` doesn't suggest that _primitive_ arrays should be supported here. Quote: > If the type of the criteria query is...

> I think it's useful It seems to me that the complexity/usefulness ratio here is really quite high.

> This is going to cause major conflicts with 7.0. So feel free to apply it, but expect to handle the conflicts Because we moved the processor to a new...

> No. Because 7.0 reuses the model between hibernate-core and the processor aaaah OK. I did not notice that. but, then, resolving the merge conflict would be as simple as...

I don't think I like this approach. How about if instead the `cast()` function just respected the setting `hibernate.use_nationalized_character_data`? So that you would write `cast(whatever as String)`, and it would...

Yeah good point, let's try to understand the use case first 👍

> I'd appreciate some help understanding why derby and oracle time out, why it doesn't build for s390x (that J9 doesn't know `var`?), why tidb cannot send emails. We've had...

This looks like a reasonable start. And this change should result in correct generation of the `on delete cascade` constraint. But I imagine that isn't quite enough. We also need...