Gavin King comments

Results 238 comments of


Gavin King

@ManyToOne defaults to eager fetching and this is almost always wrong

@gastaldi not sure what you mean ... example?

@ManyToOne defaults to eager fetching and this is almost always wrong

@gastaldi well according to what I proposed, that code would not be affected for three reasons: 1. it's already broken in JPA, since `@OneToMany` defaults to `LAZY`, 2. anyway, the...

@ManyToOne defaults to eager fetching and this is almost always wrong

Yes, probably.

@ManyToOne defaults to eager fetching and this is almost always wrong

@xDeyan indeed, it might be possible to add this to Hibernate, since using Jandex we can apparently distinguish an annotation that's explicitly set from an annotation that's defaulted. But I...

@ManyToOne defaults to eager fetching and this is almost always wrong

@AleksNo In the proposal above, there is _no change to behavior_ unless you explicitly set `jakarta.persistence.defaultFetchType=LAZY`.

@ManyToOne defaults to eager fetching and this is almost always wrong

#455 shows what this could look like.

@ManyToOne defaults to eager fetching and this is almost always wrong

`@DefaultFetchType(LAZY)` could also be a package-level annotation. This makes a lot of sense because it limits the scope of the setting, enabling incremental migration.

HHH-15846 Option to add @SuppressFBWarnings annotation on generated code

> @gavinking Are you able to review this PR, or any of the other contributors? 🙂 > Thanks Hi, I don't know what `@SuppressFBWarnings` is, nor why you want this,...

HHH-15725 Criteria API Expression.as adds cast even when the cast type is equal to the expression type

> I acknowledge that naming it treat might be a bad idea, so how about `treat_as`? Then we could name the expression class `TreatAsSqmExpression` Please, please, please no more snake...

HHH-15725 Criteria API Expression.as adds cast even when the cast type is equal to the expression type

> But anyway I don’t understand: how is this not just a flavor of `cast( as )`? So look, AFAICS, there's _no need_ for this operation in HQL. Why not?...