hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

HHH-17125 use prefixes for jaxb-generated classes

Open gavinking opened this issue 3 months ago • 6 comments

gavinking avatar Mar 25 '24 17:03 gavinking

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+     ↳ Offending commits: [e3b59c3ac3dffba03f1ef90b3756b3919dd4b17a]

› This message was automatically generated.

This is going to cause major conflicts with 7.0. So feel free to apply it, but expect to handle the conflicts

sebersole avatar Mar 25 '24 17:03 sebersole

This is going to cause major conflicts with 7.0. So feel free to apply it, but expect to handle the conflicts

Because we moved the processor to a new module, you mean?

gavinking avatar Mar 25 '24 17:03 gavinking

No. Because 7.0 reuses the model between hibernate-core and the processor

sebersole avatar Mar 25 '24 17:03 sebersole

No. Because 7.0 reuses the model between hibernate-core and the processor

aaaah OK. I did not notice that.

but, then, resolving the merge conflict would be as simple as dropping this commit, no?

gavinking avatar Mar 25 '24 18:03 gavinking

If you match the naming, then yes.

sebersole avatar Mar 25 '24 19:03 sebersole