Gavin King

Results 1136 comments of Gavin King

Yes, exactly, that's what I'm trying to say.

> [We check if the session is used in an event loop thread](https://github.com/hibernate/hibernate-reactive/blob/2a3a607d9b96ef3be1007c7ba4bf74223cd9a9d4/hibernate-reactive-core/src/main/java/org/hibernate/reactive/common/InternalStateAssertions.java#L38), so a users cannot use it in a worker thread (unless they disable the checks) Wait, what,...

Oh I get it I had forgotten that worker threads are only intended for blocking operations. Carry on. :)

> @gavinking I don't understand why h2 build fail. Do I need to relaunch the build for h2? Is it possible that this is coming from `scope.getSessionFactory().getSchemaManager().truncateMappedObjects();` which breaks h2...

@Asanio06 I was waiting for @sebersole to make the call on this, because he understands that code better than me. Also @beikov should approve.

Not at all, thank *you* for your contribution!

> Hello @gavinking @sebersole @beikov , > > Should I point to version 7 to simplify the work and not do it in 2 times? Yes, this should target `main`.

@Asanio06 I attempted to cherry-pick this onto `main`, and there were some merge conflicts, which I attempted to fix in the most obvious way, but your new test failed afterward,...

Thanks man, and Happy NY to you too!