Nicholas Gates
Nicholas Gates
This is a great start, thank you. Couple of notes/questions: * Does it only support primitive types? * nbytes is a bit funky honestly, I would grab uncompressed_len from the...
I was thinking about this recently. I think we want an ArchetypeArray (or similar). Basically a big enum of types of things that are commonly stored badly. So uuids, IP...
But we still have to pick _one_ decimal type for the builder? And for exporting to Arrow, we could even create an i128 builder and then use append_to_builder if we...
Agree with all that, and yeah the other PR has an i256 that implements NumCast, so we get back an Option to perform checked casts. Do you need the other...
Hmm, I still think the typed builder would be better. The internal enum adds another level of dispatch to most of the builder functions.
That's what I was saying about Dow casting first to DecimalBuilder, then you have a values type to downcast further to a TypedDecimalBuilder.
Yah, played with it, it's just as annoying to hold a typed thing internally.
Can we call this BitBuffer?
Where are we at with this? Need someone to takeover while you poke at FFI bindings?
Why does the memory have to be uninitialized? Even the ability to into_mut and update bits is valuable from an API perspective.