Nicholas Gates

Results 137 comments of Nicholas Gates

Could we move all imports in `dash/testing/plugin.py` inside the fixtures themselves? This might delay the bulk of the imports until the fixtures are actually invoked.

Back when I tried I don't think python-language-server had a dependency on ujson, and it could actually be made optional falling back to using the stdlib json module. That said,...

Looks like this fails in that Emscripten won't allow us to use dynamic loading and PTHREADS in the same build: https://github.com/emscripten-core/emscripten/issues/3494

That’s neat - would you be able to push up a branch for me to poke at?

Thank you for such a detailed response! It's always helpful to read up on the background to understand the reasoning behind things. I'd be interested to read more about the...

I see some changes have started merging that relate to a new read path, very exciting to see! In the meantime, I've been looking at the[ single_fragment check](https://github.com/TileDB-Inc/TileDB/blob/23c3adf4bcc152c4fc899cedc03aefb56fd8d440/tiledb/sm/query/reader.cc#L444-L446) in reader.cc...

Is that the SparseGlobalOrderReader?

Ahh, it looks like I fall through the if-statement at the moment as my arrays are sparse, don't allow duplicates, and are read with unordered layout: https://github.com/TileDB-Inc/TileDB/blob/baf64e19c37f77de6fe8b276b4f1d6499441ac83/tiledb/sm/serialization/query.cc#L976 If I switch...

Also having a dry-run mode would be really useful to experiment with consolidation parameters