Matt Westcott

Results 483 comments of Matt Westcott
trafficstars

I agree with @Stormheg. Delivering a solution that "just works" for Ukrainian transliteration solves the immediate problem - if any other situations arise in future where a custom function is...

See also #7749. I can see a possible gotcha with @kaedroho's suggestion - if the translated string is part of the migration, and a non-English locale is active when running...

It's more subtle than that - there needs to be an occurrence of `_('Can access Wagtail admin')` somewhere in the codebase so that it gets picked up by `makemessages`, but...

@SebCorbin The question is, are we 100% confident that there will never be a situation - in anyone's Wagtail project - where a language other than English is active while...

Actually, I now see that we've been using that pattern on the Page model's permissions [since at least 5.1](https://github.com/wagtail/wagtail/commit/2e94f850c2dfe765bf6e80685e6a7a7f408c490d), so a) if it wasn't safe we'd probably have seen it...

Hope I'm not too late to the party here :-) > 1. Ensuring each button can define how it can render itself As just discussed in https://github.com/wagtail/wagtail/pull/12211#issuecomment-2305832623, supporting items with...

Thanks @smark-1! Merged in 5c85c127e67e9203ace0ceacb9c860e6d7fc1114.

I received a couple of patches from a contributor who I'm not sure is on Github, with various fixes to the audio code, but I haven't had chance to review...

@yogsagot What use-case do you have that isn't covered by Wagtail's generic choosers? As far as I'm aware, all the features of wagtail-generic-chooser are now covered by Wagtail (the final...

Hi @jamesbiggs - thanks for the report. I didn't encounter anything like this when updating this package for Wagtail 5.1 last week. Often, CSS bugs on upgrade can be a...