Gabriel Scherer
Gabriel Scherer
Grmbl. The version above is not correct, as the `m̀in` should only be used when `c = !max`.
Another attempt: ```ocaml let i_max = ref max_int and max = ref (-1) in Hashtbl.iter (fun i c -> (* pick the miminal [i] which has maximal [c], and not...
I propose a minor variant of this fix in #14091.
@nojb: I'm happy to be assigned this bug, but I need someone else than me to review our proposed fix in #14091. Maybe @lthls?
Gentle ping: I have split two smaller PRs from this PR. (The commits are included there and also here, so reviewing them first is easier.) - https://github.com/ocaml/ocaml/pull/13316 , which is...
@shindere gentle ping . This PR still needs a review, and the two "smaller" PRs below it are #13316, which was reviewed by @MisterDA but needs a maintainer approval, and...
I remain interested in having someone review this. @OlivierNicole, if you are not available for an implementation review (which I can very well understand), I would still be interested in...
I rephrased the original message of this PR to emphasize what new constructs are proposed, with short usage examples. (The previous description, which is kept after that, is more about...
Thanks for the feedback. One difficulty with introducing an `if` is that currently it's easy to implement conjunction by just running the two checks in sequence, but I cannot do...
I don't mind going with `if { } ((then | else) { })*` as suggested. (There can be several `then` or `else` branch, independent of / parallel to each other.)...