Results 1654 comments of Gabriel Scherer

This still needs a full review by someone -- maybe @MisterDA or @dra27?

My impression is that we could go ahead and merge(squash) the PR in its current state, but I would like to double-check with @dra27 that he agrees. In fact, this...

It looks like precheck is currently offline due to CI maintenance (maybe @Octachron can confirm?)

I just started a precheck build at https://ci.inria.fr/ocaml/job/precheck/990/ . If it passes I'll merge.

I get a build failure on the [ocaml-mingw-32](https://ci.inria.fr/ocaml/job/precheck/990/flambda=false,label=ocaml-mingw-32/console) machine of `precheck`: ``` st_stubs.c: In function 'caml_set_current_thread_name': st_stubs.c:976:3: error: implicit declaration of function 'SetThreadDescription'; did you mean 'SetThreadDesktop'? [-Werror=implicit-function-declaration] 976 |...

No opinion here. Maybe @toots has an opinion on what is best (but I suppose tweaking the CI is something someone else would do), otherwise of course @dra27 could provide...

I ran a new [precheck build](https://ci.inria.fr/ocaml/job/precheck/991/) and unfortunately this still fails with the msvc-64 CI machine: ``` CC st_stubs.b.obj st_stubs.c st_stubs.c(28): error C2220: l'avertissement suivant est traité comme une erreur...

The third iteration of precheck build ([#992](https://ci.inria.fr/ocaml/job/precheck/992/)) is now successful, thanks @toots and @MisterDA! Merging now.

Yes, apologies for clicking the wrong button.

I'm surprised that `let open%foo M in ()` works in the first place, I would have expected `let%foo open M in ()` instead. (Is the extension not consistently on the...