Gabriel Scherer
Gabriel Scherer
(Is this still a draft?)
@OlivierNicole I agree with your risk/benefit analysis, and I would encourage you to merge based on this assessment.
So `stable_subsort`?
> Also about collecting them in a submodule I think I'd rather not. A submodule would make more sense if a new kind of value holding indices on the subarray...
I am not sure about a warning: - presumably all *existing* code using the feature is written by people who are aware of the effect (otherwise you get into unexpected...
Here would be my proposal: ``` In particular, the shallow copy of @'x'@ in the definition @'let' 'y' '=' '{' 'x' 'with' \ldots '}'@ ensures that updates to a mutable...
@MisterDA if you want to ask me for more refactoring work than what I need, you need to pay me with a full review :-)
@MisterDA volunteered to review this.
I think that @MisterDA is probably the right person to get in touch with to fix these specific issues you are reporting -- adding more conditional macros for `[[noreturn]]`, `_Alignas`...
It looks like this is not a upstream Dune problem, as `-x c++` is passed by the configuration layer of the mcss package itself (see https://github.com/ocaml-opam/ocaml-mccs/pull/53): https://github.com/ocaml-opam/ocaml-mccs/blob/072fbd17eb38536a73aa73a29ec15b27738cb272/src/context_flags.ml#L26 What value of...