Results 115 comments of Gary Miguel

If you just upload a CL and forget to assign reviewers, the default status is not WIP, is it?

For my most commonly used Gerrit hosts, the default state is "active". Since it seems to be a configuration option in Gerrit, could we make this a configuration option in...

Given this plugin is not chromium-specific, could we make the behavior not chromium-specific?

I'll try terminology and see if that works. On Tue, Jul 7, 2015 at 6:45 PM, Tom Dryer [email protected] wrote: > I'm not sure it's possible to fix this in...

Don't forget the version converter support. Might be non-trivial for this change.

Could you please add `Fixes #4106` to the PR description?

Rama told me in person that: * He wants this PR to also include redefining the ConvTranspose op as a function using the new Col2Im op. * He wants Col2Im...

@thiagocrepaldi looks like ORT uses Col2imND for ConvTranspose: https://cs.github.com/microsoft/onnxruntime/blob/2dfd81b9bb097c90388010e5b7d298498274f8d9/onnxruntime/core/providers/cpu/nn/conv_transpose.cc?q=repo%3Amicrosoft%2Fonnxruntime+Col2Im#L192 So if they already have an N-dimensional Col2im implementation, the question is can we generalize the ONNX op spec to support...

@thiagocrepaldi I think my original question is still the important one: can we generalize the ONNX op spec to support Col2imND such that it's easy to re-use the existing implementation...