Gary Tou

Results 121 comments of Gary Tou

## Where do we define all the possible notification types? Notification types are composed of a `model` and `subtype`. For example, `AchTransfer` and `:create`. I think, we should store them...

`Activity` tells us what happened, and then `Notification` is responsible for notifying people about that `Activity`. - Notification belongs_to Activity - Notification has_many recipients (Users) - Notification model is responsible...

> @garyhtou would we be able to create a `NotificationSettings` model? > > I'm thinking one can be attached to each user and it'd be easier to reference in code...

If we want to allow digests/summaries. We need to know whether a notification has already been delivered to a specific user. To make this happen, `Notification has_many recipients (Users)` should...

Consider researching https://github.com/excid3/noticed FYI, Rails is also working on a native notification system, but don't waiting for this block us. https://github.com/rails/rails/issues/50454

Thanks for the reply and fixes, @lachlanjc. Feel free to ping me when this is ready for another review! I know you're busy, so if you'd like us to handle...

I'd recommend reading this guide about [Mailers](https://guides.rubyonrails.org/action_mailer_basics.html). Focus on sections 1, 2, 4 (first two paragraphs only), 5, 9, and skim 7. As a first step, you’ll want to create...