hcb icon indicating copy to clipboard operation
hcb copied to clipboard

[UI] Visual refresh across core components

Open lachlanjc opened this issue 1 year ago • 8 comments

Summary of the problem

We've had the same plastic-y looking buttons that grab focus with slightly garish colors & shadows for 4 years. They've been fun, but now that we have more pages & more features, elements are competing for attention, and it makes the app mentally more burdensome to use than necessary. We can tone down some of these colors & font sizes & shadows and improve peace & clarity across the site. It's a new era for HCB!

Describe your changes

I've refreshed styling across:

  • Card shadows
  • Buttons
  • Menus (dropping the loud hover state)
  • Inputs (including now having two sizes, one smaller one for search bars so they fit perfectly)
  • Dock
  • Filterbars

CleanShot 2024-08-27 at 17 51 10@2x CleanShot 2024-08-27 at 17 51 31@2x CleanShot 2024-08-27 at 17 51 00@2x

The transaction filter menu shows the input/menu changes the best. I've removed the visual jiggling on hover, and fixed the different input heights across the tabs, the tabs adjusting width as they're selected, the size of the tabs, the width of the dividers:

https://github.com/user-attachments/assets/cc8b6e04-f90f-4a43-99e7-6e20966bb5fa

lachlanjc avatar Aug 27 '24 21:08 lachlanjc

Moving the Export button up to the top is a sweet move; it's been awkwardly hovering there for a while :D

sampoder avatar Aug 27 '24 22:08 sampoder

cc: @malted & @YodaLightsabr what do you all think? want to make sure everyone gets a chance to join in

sampoder avatar Aug 31 '24 20:08 sampoder

Thank you for all your QA, @sampoder! Ready for another round whenever you have a moment. I don't have almost any sample data locally to test against, so I can't see all the potential states.

lachlanjc avatar Sep 04 '24 22:09 lachlanjc

I would love to get this merged ASAP to reduce merge conflicts & unblock some other PRs! Do you want to do more QA @sampoder? Anything I can help with?

lachlanjc avatar Sep 16 '24 15:09 lachlanjc

Sorry I missed this comment, please feel free to contact me via Slack (I get a lot of GitHub notifs!). I'm waiting to hear about others thoughts about this at the moment

sampoder avatar Sep 23 '24 20:09 sampoder

Thanks for the reply and fixes, @lachlanjc. Feel free to ping me when this is ready for another review!

I know you're busy, so if you'd like us to handle the fixes, I'm also happy to do that. If you are interested, please give me a thumbs-up so that we're on the same page for the feedback above. We'll then edit this branch to address the feedback and get it ready to merge. Same thing for https://github.com/hackclub/hcb/pull/7773!

garyhtou avatar Oct 21 '24 20:10 garyhtou

I've merged the branches & implemented some changes based on feedback! https://www.loom.com/share/c3bcc398ce40471f80047f7702b528f1

Please run with this from here—I'm sure there's some assorted bugs to catch etc. I haven't worked on the new mobile nav yet at all, only the desktop one.

lachlanjc avatar Jan 08 '25 07:01 lachlanjc

@lachlanjc so happy with this, thank you!! For some context, I met with @garyhtou and Mel and I'm going to start adding items here to finish this PR. @lachlanjc the team will finish this :)

  • [ ] On mobile, quick actions should wrap and horizontally scroll, right now vertical

  • [ ] When using a “card with a footer” the borders are not consistent, don’t show up on the bottom

  • [ ] Break points are likely inconsistent, which causes Command K bar to show in mobile view. Happens when screen is 960px wide Screenshot 2025-01-17 at 11 45 19 AM

  • [ ] Mobile nav breaks, another breakpoint issue. 1024px is high range, low range is 768px Screenshot 2025-01-17 at 11 45 41 AM Screenshot 2025-01-17 at 11 45 38 AM

  • [ ] Rename internal hcb transfers to HCB Book Transfer. This needs to be updated on the Transfers page and the quick action on the Overview page.

  • [ ] Add “International wires” to transfer dropdown on Overview

dwahbe avatar Jan 17 '25 17:01 dwahbe