Gary Gregory
Gary Gregory
It sounds like we are ok with this PR then. @elharo @michael-o ?
Hi all, @arthurscchan , @elharo I've reviewed this PR, the code, and pushed to git master with better input checks: - Conversion.hexTo*() methods now throw `IllegalArgumentException` instead of `StringIndexOutOfBoundsException` -...
After reworking the class locally to throw IEA instead of `[Array|String]IndexOutOfBoundsException`, it looks like we work too hard for the happy path when some of the APIs already document `[Array|String]IndexOutOfBoundsException`....
@seadbrane Why? FTR https://issues.apache.org/jira/projects/LANG/issues/LANG-1172 CC: @c-w
Hi @seadbrane If you want this issue to get more visibility, you should consider posting to the developer's mailing list https://commons.apache.org/mail-lists.html
Hello @obfischer - The tests don't assert that the stopwatch measured time. - Another assertion would be that the lambda asserts that the stopwatch is running while it is invoked....
@obfischer Sure, I don't see why not.
I don't see why mocking is needed in the first place since the stopwatch state change can be asserted from the lambda, but let's see.
@obfischer Run `mvn` by itself before you push to catch all builds failures.