Gary Gregory
Gary Gregory
> But it was a really bad idea. I agree on that one! 😉
Shouldn't we make this more sane for 3.0 and get rid of this special hidden behavior? It would better IMO.
@stefansimon76 This PR currently has zero tests and no helpful explanation in the PR description.
Closing: No reply in 2 weeks.
Hello @akuhtz If you want to use this feature, you have to give it permission, please see https://github.com/apache/commons-lang/blob/9babe58d895a0e4d6563268ca188794fbf066b38/pom.xml#L468
@kangxy There are no tests in this PR. You'll want a test that fails if there are no changes to the main directory.
Is there anything else needed to move this out of the draft stage?
@arthurscchan I'm not so sure about this one. Maybe the original runtime exception should be rethrown as an `IllegalArgumentException`.
I agree this PR should be closed as is. I'll leave it open for now if @arthurscchan wants to update it with code changes instead.
@elharo and all Taking the same approach as `java.util.Arrays` seems reasonable but that class checks and throws exceptions (IAE and ArrayIndexOutOfBoundsException) explicitly instead of letting code fail. Thoughts?