Gary Gregory
Gary Gregory
Hi @funky-eyes See my previous comments. With JEP 491 in JDK 24, a significant improvement has been made regarding virtual threads and synchronized blocks. Virtual threads can now acquire, hold,...
No objection here.
Hello @SteveOswald This PR needs a test to prove the PR fixes something and to avoid regressions.
Still missing tests
> We are facing the same problem connecting to FTP servers behind a squid proxy, any chance for a new release ? Hi @marwenlahmar, Finally coming back to these parts......
20 files changed files and zero tests is not good. Try and see if Mockito helps.
Hello @theshoeshiner ! At a high level I am ok with the feature but the implementation seems seems potentially wasteful because two proxies are always created. My thinking is that...
@theshoeshiner Always run 'mvn' by itself to catch these build errors before you push.
@theshoeshiner Thank you for your detailed reply. To be clear, let me ask: Your use case requires the same instance to support both fire-all and fire-fail-fast?
@theshoeshiner The build is still broken. Run 'mvn' by itself before you push.