Gary Gregory
Gary Gregory
@nbauma109 Thank you for the reply and please accept my apologies for the delay, I'll come back around to this PR this week.
Hi @nbauma109 I apologize for the delay. - The next version for new APIs should be `@since 6.10.0` - Please rebase on git master - Run `mvn` (by itself) and...
Hi @markro49 Would you have any issues on your end with this PR? Looks good to me.
Merged, TY @markro49 !
@PabloNicolasDiaz Thank you for your PR. I fixed a whole set of whitespace issues. 1. Please rebase on Git master to pick up a new version of our Checkstyle configuration,...
@PabloNicolasDiaz The build is broken with: ``` Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp (default-cli) on project bcel: There is at least one incompatibility: org.apache.bcel.classfile.Visitor.visitRecordComponent(org.apache.bcel.classfile.RecordComponentInfo):METHOD_ADDED_TO_INTERFACE -> [Help 1] ``` Use a...
@PabloNicolasDiaz The PR still causes the build to fail. Also, note that the code coverage is insufficient as reported by Codecov: ``` Attention: Patch coverage is 50.56180% with 44 lines...
@PabloNicolasDiaz It does not look like you rebased on git master and run `mvn` locally because this fails for me: ``` git apply ~/Downloads/290.diff.txt .../Downloads/290.diff.txt:402: trailing whitespace. .../Downloads/290.diff.txt:445: trailing whitespace....
Hello @PabloNicolasDiaz Thank you for your update. The current code coverage is poor as reported by JaCoCo, for example, the new Record class is only at 66% and 58% for...
@PabloNicolasDiaz Again, rebase on git master if you haven't, run `mvn` (or the same as `maven.yml`: `mvn --show-version --batch-mode --no-transfer-progress -DtrimStackTrace=false -Ddoclint=none`), and fix issues, starting with: ``` git apply...