Gary L comments

Repositories
Issues
Comments

Results 3 comments of


                                            Gary L

Npm test fix

Just sync some changes to make this PR no conflict with the upstream.

Write / Build Code review guide/site/app/video/something

For reviewers, I found [this video](https://codeyourfuture.slack.com/files/U04ES157RPC/F06NTVD8TS8/code_review_on_github_english.mp4), [guidance on reviews](https://curriculum.codeyourfuture.io/guides/reviewing/) and [this example](https://github.com/CodeYourFuture/Module-HTML-CSS/pull/186) are quite useful, and did some review based on it. Those guides may be a good point to...

`whoami` has 0 coverage on Windows

It seems that CI bypasses the only common test covered in Windows. https://github.com/uutils/coreutils/blob/e920d8d1bdc9c6e59f577b3d415fd993cc609578/tests/by-util/test_whoami.rs#L42-L52 Can I fix it by adding a dummy command test in Windows? ```rust #[test] #[cfg(windows)] fn test_normal_windows()...