coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

`whoami` has 0 coverage on Windows

Open sylvestre opened this issue 2 years ago • 3 comments

Maybe the test isn't executed on Windows?

https://app.codecov.io/gh/uutils/coreutils/blob/main/src/uu/whoami/src/platform/windows.rs

sylvestre avatar Mar 24 '23 20:03 sylvestre

It seems that CI bypasses the only common test covered in Windows. https://github.com/uutils/coreutils/blob/e920d8d1bdc9c6e59f577b3d415fd993cc609578/tests/by-util/test_whoami.rs#L42-L52

Can I fix it by adding a dummy command test in Windows?

#[test]
#[cfg(windows)]
fn test_normal_windows() {
    new_ucmd!().succeeds().no_stderr();
}

garydev10 avatar May 25 '23 18:05 garydev10

yeah, let's try that :)

sylvestre avatar May 25 '23 21:05 sylvestre

Should this be closed?

augustebaum avatar May 28 '25 20:05 augustebaum