Garrett Moon

Re-enable TTL Tests

1

TTL tests were not behaving reliably and were failing intermittently. We need to make sure they work reliably and re-enable.

Removes the optimization to reduce the display links frame interval

3

The idea behind this optimization was to reduce the number of calls the display link would need for animated images which didn't draw every frame. But this has resulted in...

Allow custom downloader

1

Specifically look at `PINURLSessionManager` (class), `sessionTaskWithURL:key:options:priority:` (in PINRemoteImageManager) `downloadDataWithURL:key:priority:completion:` (in PINRemoteImageManager) and `PINDataTaskOperation` (class) To be frank, it could definitely use a bit of cleanup to make things clearer. There...

Without this we see the following error in Xcode 12.5 with strict-prototypes enabled. ResumableAssert.m:30:38: error: this old-style function definition is not preceded by a prototype [-Werror,-Wstrict-prototypes]

ratedThisVersion not set if using SKStoreReviewController?

4

It appears as if ratedThisVersion is not set when requesting reviews with SKStoreReviewController? If I'm reading things correctly, the rate method is never called. This would mean that once the...