Garrett Moon comments

Results 59 comments of


                                            Garrett Moon

Create a static library target

@vlozko sounds like a good optimization, one thing to consider is that PINCache is optional.

Allow setting a new instance to [PINRemoteImage sharedManager]

I would love to see this as well and would happily review [RFC]s on how to do it!

#trivial Fix: Download fail when using processor with GIF image

Can you please rebase this? (sorry for the delayed review!)

Add a method to cancel all tasks

@sainttail I don't think there is a way currently. That method would either need to be added or, as you said, you'd need to keep track of all available tasks....

Error:(27, 18) use of undeclared type 'PINAnimatedImageView'

@choiks14 can you provide a bit more information? PINAnimatedImageView is a UIImageView subclass which displays animated images (GIF and webp so far).

Add support for UIButton setBackgroundImage?

Happy to accept a pull request to add this support!

Add support for UIButton setBackgroundImage?

Thank you! I'll try and take a look soon.

Remove carthage folder

Like the PINCache PR I don't think we can just remove Carthage – the current setup has the project built with it.

UIView category completion methods should be called on the main thread.

@k06a what version specifically? Master has a dispatch to the main queue automatically.

UIView category completion methods should be called on the main thread.

Hmm, that's very surprising. 2.0.1 has this behavior as well. Mind doing a little bit of diagnosis? Putting a breakpoint into the completion callback and seeing where it goes and...