Massimiliano Arione

Results 255 comments of Massimiliano Arione

You shoudl also add "It's abandoned" :disappointed:

@IonBazan I'm not against the interface change, but this PR should include an update to changelog

For testing, installing [docker](https://www.docker.com/) should be enough

Try removing your composer.lock file before running. Probably we should add a step to our Makefile to do that.

> The static analysis must have failed before. It didn't. The error is clearly introduced by your changes.

![Screenshot from 2022-07-22 11-13-14](https://user-images.githubusercontent.com/179866/180406616-b65f0214-9404-4eb4-978e-65326b1ee0af.png)

> The return type of the method differs from the return type given in the PhpDoc, that was the case before my changes already too: > > https://github.com/dustin10/VichUploaderBundle/blob/23ee93cd3b84afaa20ce69ba8399a9098bdb07f6/src/Mapping/PropertyMapping.php#L75-L79 > >...

You can take a look to https://github.com/dustin10/VichUploaderBundle/blob/master/tests/Storage/StorageTestCase.php to see how to deal with filesystem in tests

We're almost there! You only need to add a documentation page