Gustavo Antunes

Results 61 comments of Gustavo Antunes

Approved for @MetaMask/account-management Checked the following PRs were included and working in release PR - [x] https://github.com/MetaMask/metamask-extension/pull/25200 - [x] https://github.com/MetaMask/metamask-extension/pull/25437 - [x] https://github.com/MetaMask/metamask-extension/pull/25291 - [x] https://github.com/MetaMask/metamask-extension/pull/25423 - [x] https://github.com/MetaMask/metamask-extension/pull/25491 -...

I agree with your statement @legobeat. This was the reason I did it as `string` in the first place and later I decided to make this change because we only...

@caiquecruz now you need to update the snapshot for that component, ``` yarn test:unit:update ```

This PR can be merged with a SonarCloud Code Analysis check bypass

Adding this to the accounts board so we can do some research about the issue

I was not able to fully test the wallet details feature because of a few bugs that are not related to this PR, the first related to when you activate...

@tommasini a recording of what specifically? This PR does not have an UI/UX impact

@tommasini thanks for the clarification, I'll post the videos for account creation and SRP import

> @gantunesr, for context, why is SHA-512/256 being used here? Is there any specific reason? (I'm not trying to imply that it's not ok, but just to understand the reason.)...

@plasmacorral can you double check if the biometric bug is from this PR? That issue seems unrelated to these changes and I believe it is not being introduced here