metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat: QR-based add NGRAVE ZERO Hardware

Open xardass opened this issue 1 year ago • 2 comments

Description

Hello,

This PR changes the UI and text to add the NGRAVE ZERO hardware wallet.

Our upcoming release planned for the beginning of July will add QR code compatibility with MetaMask following EIP-4527.

Related issues

Fixes:

See the corresponding changes in the extension: https://github.com/MetaMask/metamask-extension/pull/25080

Manual testing steps

  1. Add a QR based wallet on MetaMask Mobile
  2. Scan the QR code from the hardware wallet.

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

xardass avatar Jun 12 '24 08:06 xardass

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 12 '24 08:06 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

caiquecruz avatar Jun 12 '24 13:06 caiquecruz

@xardass You PR is approved but there are some conflicts that must be resolved. Can you take care of that so we can proceed with merge? Thanks 🙂

Akaryatrh avatar Aug 01 '24 07:08 Akaryatrh

Looks like there's a lint issue because of an unused variable

Just removed, thank you!

caiquecruz avatar Aug 01 '24 14:08 caiquecruz

@caiquecruz now you need to update the snapshot for that component,

yarn test:unit:update

gantunesr avatar Aug 01 '24 15:08 gantunesr

hi, @xardass the PR has been approved by two code reviewer and has qa passed tag. so you can Squash and merge the PR now.

dawnseeker8 avatar Aug 12 '24 08:08 dawnseeker8

This PR can be merged with a SonarCloud Code Analysis check bypass

gantunesr avatar Aug 12 '24 18:08 gantunesr