metamask-mobile
metamask-mobile copied to clipboard
feat: QR-based add NGRAVE ZERO Hardware
Description
Hello,
This PR changes the UI and text to add the NGRAVE ZERO hardware wallet.
Our upcoming release planned for the beginning of July will add QR code compatibility with MetaMask following EIP-4527.
Related issues
Fixes:
See the corresponding changes in the extension: https://github.com/MetaMask/metamask-extension/pull/25080
Manual testing steps
- Add a QR based wallet on MetaMask Mobile
- Scan the QR code from the hardware wallet.
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
I have read the CLA Document and I hereby sign the CLA
@xardass You PR is approved but there are some conflicts that must be resolved. Can you take care of that so we can proceed with merge? Thanks 🙂
Looks like there's a lint issue because of an unused variable
Just removed, thank you!
@caiquecruz now you need to update the snapshot for that component,
yarn test:unit:update
hi, @xardass the PR has been approved by two code reviewer and has qa passed tag. so you can Squash and merge the PR now.
This PR can be merged with a SonarCloud Code Analysis check bypass