metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Version v12.1.0

Open chloeYue opened this issue 1 year ago • 3 comments

RC V12.1.0

Open in GitHub Codespaces

chloeYue avatar Jun 28 '24 16:06 chloeYue

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 28 '24 16:06 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 28 '24 16:06 sonarqubecloud[bot]

Builds ready [652591f]
Page Load Metrics (412 ± 328 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint651681132411
domContentLoaded105833147
load422236412683328
domInteractive105833147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jun 28 '24 19:06 metamaskbot

Bug report for v12.1.0: https://github.com/MetaMask/MetaMask-planning/issues/2729

chloeYue avatar Jul 01 '24 09:07 chloeYue

Hi! We need teams' approval on July 15 for V12.1.0. Please note that if your team still has ongoing work on V12.0.0, you should prioritize that. In case any more issues arise for V12.0.0, we will push back sign-offs on V12.1.0. Let's do this! :rocketship:

Instructions for Team Review

Review Changes: Refer to the Release Tracker for v12.1.0 to see all changes relevant to your team.

Log Bugs: If you find any issues, log them in the release tracker and attach them to the bug report.

Approval: After reviewing, indicate your team's approval by:

  • Marking the checkbox next to your team's name in this comment.
  • Optionally, leave a comment for additional information.

Your thorough review ensures a smooth and successful release. If you have any questions please reach out to extension platform team or in the #metamask-qa slack channel. Thank you for your collaboration!

  • [x] Accounts: @gantunesr - There are 19 Accounts changes in v12.1.0
  • [x] Assets: @sahar-fehri / @alfeng6 - There are 18 Assets changes in v12.1.0
  • [x] Bridging: @micaelae / @BZahory - There are 7 Bridging changes in v12.1.0
  • [x] Confirmations: @sleepytanya / @cryptotavares - There are 32 Confirmations changes in v12.1.0.
  • [x] Design/Systems: @georgewrmarshall - There are 18 Design/Systems change in v12.1.0.
  • [x] MMI: @zone-live / @shane-t - There are 6 MMI changes in v12.1.0.
  • [x] Notifications: @Prithpal-Sooriya / @matteoscurati - There are 11 Notifications changes in v12.1.0
  • [x] Ramps: @georgeweiler - There is 1 Ramps change in v12.1.0.
  • [x] Snaps: @bowensanders / @FrederikBolding / @Montoya - There are 5 Snaps changes in v12.1.0.
  • [x] Swaps: @davibroc / @dan437 - There are 4 Swaps change in v12.1.0.
  • [x] Wallet API: @adonesky1 @jiexi - There are 9 Wallet API changes in v12.1.0.
  • [x] Wallet Framework: @Gudahtt - There are 10 Wallet Framework changes in v12.1.0.
  • [x] Wallet UX: @darkwing / @NidhiKJha - There are 8 Wallet UX changes in v12.1.0.

benjisclowder avatar Jul 05 '24 12:07 benjisclowder

Manual test scenarios:

Chrome

  • [x] Onboarding - create a wallet
  • [x] Onboarding - import a wallet
  • [x] Keyring - connect hardware wallet
  • [x] Keyring - reset a wallet
  • [x] Transactions - send native token origin MM
  • [x] Transactions - send native token origin dapp
  • [x] Transactions - send ERC20 token origin MM
  • [x] Transactions - send ERC20 token origin dapp
  • [x] Transactions - send ERC721 token origin MM
  • [x] Transactions - send ERC721 token origin dapp
  • [x] Transactions - speed up transaction
  • [x] Transactions - cancel transaction
  • [x] Transactions - deploy failing transaction
  • [x] Transactions - deposit and withdraw
  • [x] Transactions - navigate multiple transactions
  • [ ] Transactions - send transactions with custom nonce - https://github.com/MetaMask/metamask-extension/issues/22089
  • [x] Transactions - cancel transaction using same nonce
  • [x] Tokens - import ERC20 token origin MM
  • [x] Tokens - import ERC20 token origin dapp
  • [x] Tokens - import ERC721 token origin MM
  • [x] Tokens - import ERC721 token origin dapp
  • [ ] Tokens - import ERC1155 token origin MM - https://github.com/MetaMask/metamask-extension/issues/26424
  • [ ] Tokens - import ERC1155 token origin dapp - https://github.com/MetaMask/metamask-extension/issues/26424
  • [x] Tokens - approve ERC1155 token
  • [x] Tokens - approve ERC20 token
  • [x] Tokens - approve ERC721 token
  • [x] Tokens - autodetect tokens
  • [ ] Tokens - autodetect NFTs - could not test without NFTs on Mainnet
  • [x] Tokens - approve erc20 custom amount
  • [x] ENS - name resolution
  • [x] Phishing - warning page
  • [x] Network - add custom network manually
  • [x] Network - add custom network from the list of popular networks
  • [x] Network - add custom network from dApp
  • [x] Network - update networks
  • [x] Network - switching networks
  • [x] Network - delete networks from the dropdown list
  • [x] Network - delete networks in Settings
  • [x] Backup - backup user data
  • [x] Backup - restore user data
  • [x] Metrics - send event metrics
  • [ ] Address-book - add a contact to the address book https://github.com/MetaMask/metamask-extension/issues/26471
  • [x] Address-book - remove a contact from the address book
  • [ ] Address-book - update a contact in the address book
  • [x] Gas fee - EIP-1559 gas
  • [x] Gas fee - legacy gas
  • [x] Sign - personal sign
  • [x] Sign - sign in with ethereum
  • [x] Sign - sign typed with data
  • [x] Sign - sign typed data v3 with hardware wallet
  • [x] Sign - sign typed data v4 with hardware wallet
  • [x] Sign - personal sign with hardware wallet
  • [x] Permissions - connecting and disconnecting from a dapp
  • [x] Swap - smart swap
  • [x] Swap - swap eth
  • [x] Incoming transactions - receive native token - cannot see Sepolia ETH in my activity list (in the receiver account activity
  • [x] Settings - about MetaMask
  • [x] Settings - general - change language - https://github.com/MetaMask/metamask-extension/issues/25698
  • [x] Settings - advanced - check custom nonce toggle
  • [x] Settings - advanced - show hex data
  • [x] Contract - deploy contract, mint and import NFT with hardware wallet
  • [x] Contract - hardware wallet qr based connect
  • [x] Contract - send token with hardware wallet

Firefox

  • [x] Onboarding - create a wallet
  • [x] Onboarding - import a wallet
  • [ ] Keyring - connect hardware wallet
  • [ ] Keyring - reset a wallet
  • [x] Transactions - send native token origin MM
  • [x] Transactions - send native token origin dapp
  • [x] Transactions - send ERC20 token origin MM
  • [x] Transactions - send ERC20 token origin dapp
  • [x] Transactions - send ERC721 token origin MM
  • [x] Transactions - send ERC721 token origin dapp
  • [x] Transactions - speed up transaction
  • [x] Transactions - cancel transaction
  • [x] Transactions - deploy failing transaction
  • [ ] Transactions - deposit and withdraw
  • [x] Transactions - navigate multiple transactions
  • [ ] Transactions - send transactions with custom nonce
  • [x] Transactions - cancel transaction using same nonce
  • [x] Tokens - import ERC20 token origin MM
  • [x] Tokens - import ERC20 token origin dapp
  • [x] Tokens - import ERC721 token origin MM
  • [x] Tokens - import ERC721 token origin dapp
  • [ ] Tokens - import ERC1155 token origin MM
  • [ ] Tokens - import ERC1155 token origin dapp
  • [x] Tokens - approve ERC1155 token
  • [x] Tokens - approve ERC20 token
  • [x] Tokens - approve ERC721 token
  • [x] Tokens - autodetect tokens
  • [x] Tokens - autodetect NFTs
  • [x] Tokens - approve erc20 custom amount
  • [ ] ENS - name resolution - does not recognize ENS in testnets
  • [x] Phishing - warning page
  • [x] Network - add custom network manually
  • [x] Network - add custom network from the list of popular networks
  • [x] Network - add custom network from dApp
  • [x] Network - update networks
  • [x] Network - switching networks
  • [x] Network - delete networks from the dropdown list
  • [x] Network - delete networks in Settings
  • [x] Backup - backup user data
  • [x] Backup - restore user data
  • [x] Metrics - send event metrics
  • [ ] Address-book - add a contact to the address book
  • [x] Address-book - remove a contact from the address book
  • [ ] Address-book - update a contact in the address book
  • [x] Gas fee - EIP-1559 gas
  • [x] Gas fee - legacy gas
  • [x] Sign - personal sign
  • [x] Sign - sign in with ethereum
  • [x] Sign - sign typed with data
  • [ ] Sign - sign typed data v3 with hardware wallet
  • [ ] Sign - sign typed data v4 with hardware wallet
  • [ ] Sign - personal sign with hardware wallet
  • [x] Permissions - connecting and disconnecting from a dapp
  • [x] Swap - smart swap
  • [ ] Swap - swap eth
  • [x] Incoming transactions - receive native token
  • [x] Settings - about MetaMask
  • [ ] Settings - general - change language - https://github.com/MetaMask/metamask-extension/issues/25698
  • [x] Settings - advanced - check custom nonce toggle
  • [x] Settings - advanced - show hex data
  • [ ] Contract - deploy contract, mint and import NFT with hardware wallet
  • [ ] Contract - hardware wallet qr based connect
  • [ ] Contract - send token with hardware wallet

benjisclowder avatar Jul 11 '24 12:07 benjisclowder

Approved for @MetaMask/account-management

Checked the following PRs were included and working in release PR

  • [x] https://github.com/MetaMask/metamask-extension/pull/25200
  • [x] https://github.com/MetaMask/metamask-extension/pull/25437
  • [x] https://github.com/MetaMask/metamask-extension/pull/25291
  • [x] https://github.com/MetaMask/metamask-extension/pull/25423
  • [x] https://github.com/MetaMask/metamask-extension/pull/25491
  • [x] https://github.com/MetaMask/metamask-extension/pull/25257
  • [x] https://github.com/MetaMask/metamask-extension/pull/25003
  • [x] https://github.com/MetaMask/metamask-extension/pull/25326
  • [x] https://github.com/MetaMask/metamask-extension/pull/25314
  • [x] https://github.com/MetaMask/metamask-extension/pull/25313
  • [x] https://github.com/MetaMask/metamask-extension/pull/25290
  • [x] https://github.com/MetaMask/metamask-extension/pull/25038
  • [x] https://github.com/MetaMask/metamask-extension/pull/25287
  • [x] https://github.com/MetaMask/metamask-extension/pull/25241
  • [x] https://github.com/MetaMask/metamask-extension/pull/25143
  • [x] https://github.com/MetaMask/metamask-extension/pull/25205
  • [x] https://github.com/MetaMask/metamask-extension/pull/25201
  • [x] https://github.com/MetaMask/metamask-extension/pull/25096

gantunesr avatar Jul 16 '24 19:07 gantunesr

Firefox v.12.1.0 (I still cannot edit the above checklist)

  • [x] Onboarding - create a wallet
  • [x] Onboarding - import a wallet
  • [ ] Keyring - connect hardware wallet
  • [x] Keyring - reset a wallet
  • [x] Transactions - send native token origin MM
  • [x] Transactions - send native token origin dapp
  • [x] Transactions - send ERC20 token origin MM
  • [x] Transactions - send ERC20 token origin dapp
  • [x] Transactions - send ERC721 token origin MM
  • [x] Transactions - send ERC721 token origin dapp
  • [x] Transactions - speed up transaction
  • [x] Transactions - cancel transaction
  • [x] Transactions - deploy failing transaction
  • [ ] Transactions - deposit and withdraw - extension was unresponsive/test failed
  • [x] Transactions - navigate multiple transactions
  • [x] Transactions - send transactions with custom nonce
  • [x] Transactions - cancel transaction using same nonce
  • [x] Tokens - import ERC20 token origin MM
  • [x] Tokens - import ERC20 token origin dapp
  • [x] Tokens - import ERC721 token origin MM
  • [x] Tokens - import ERC721 token origin dapp
  • [ ] Tokens - import ERC1155 token origin MM - could not import token manually after minting
  • [ ] Tokens - import ERC1155 token origin dapp- could not import token via dapp after minting
  • [x] Tokens - approve ERC1155 token
  • [x] Tokens - approve ERC20 token
  • [x] Tokens - approve ERC721 token
  • [x] Tokens - autodetect tokens
  • [x] Tokens - autodetect NFTs
  • [x] Tokens - approve erc20 custom amount
  • [x] ENS - name resolution
  • [x] Phishing - warning page
  • [x] Network - add custom network manually
  • [x] Network - add custom network from the list of popular networks
  • [x] Network - add custom network from dApp
  • [x] Network - update networks
  • [x] Network - switching networks
  • [x] Network - delete networks from the dropdown list
  • [x] Network - delete networks in Settings
  • [x] Backup - backup user data
  • [x] Backup - restore user data
  • [ ] Metrics - send event metrics
  • [ ] Address-book - add a contact to the address book - https://github.com/MetaMask/metamask-extension/issues/25918
  • [x] Address-book - remove a contact from the address book
  • [x] Address-book - update a contact in the address book
  • [x] Gas fee - EIP-1559 gas
  • [x] Gas fee - legacy gas
  • [x] Sign - eth sign
  • [x] Sign - personal sign
  • [x] Sign - sign in with ethereum
  • [x] Sign - sign typed with data
  • [ ] Sign - sign typed data v3 with hardware wallet
  • [ ] Sign - sign typed data v4 with hardware wallet
  • [ ] Sign - personal sign with hardware wallet
  • [ ] Sign - eth sign with hardware wallet
  • [x] Permissions - connecting and disconnecting from a dapp
  • [x] Swap - smart swap
  • [x] Swap - swap eth
  • [x] Incoming transactions - receive native token
  • [x] Settings - about MetaMask
  • [x] Settings - general - change language - Hindi translations look good on all screens, but Spanish, Dansk, Magyar, and Arabic translations partially failed.
  • [x] Settings - advanced - check custom nonce toggle
  • [x] Settings - advanced - show hex data
  • [ ] Contract - deploy contract, mint and import NFT with hardware wallet
  • [ ] Contract - hardware wallet qr based connect
  • [ ] Contract - send token with hardware wallet

katkopel avatar Jul 18 '24 01:07 katkopel

Builds ready [a87217d]
Page Load Metrics (88 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint653681227235
domContentLoaded985372010
load40269885325
domInteractive985372010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.5 KiB (0.05%)
  • common: 276 Bytes (0.00%)

metamaskbot avatar Jul 18 '24 18:07 metamaskbot

🟢 Approved for @MetaMask/design-system-engineers

Checked the following PRs were included and working in release PR:

  • https://github.com/MetaMask/metamask-extension/pull/25122
  • https://github.com/MetaMask/metamask-extension/pull/25124
  • https://github.com/MetaMask/metamask-extension/pull/25011
  • https://github.com/MetaMask/metamask-extension/pull/25010
  • https://github.com/MetaMask/metamask-extension/pull/25083
  • https://github.com/MetaMask/metamask-extension/pull/25158
  • https://github.com/MetaMask/metamask-extension/pull/24971
  • https://github.com/MetaMask/metamask-extension/pull/24953
  • https://github.com/MetaMask/metamask-extension/pull/25019
  • https://github.com/MetaMask/metamask-extension/pull/25050
  • https://github.com/MetaMask/metamask-extension/pull/25228
  • https://github.com/MetaMask/metamask-extension/pull/25176
  • https://github.com/MetaMask/metamask-extension/pull/25237
  • https://github.com/MetaMask/metamask-extension/pull/25225
  • https://github.com/MetaMask/metamask-extension/pull/25017
  • https://github.com/MetaMask/metamask-extension/pull/25149
  • https://github.com/MetaMask/metamask-extension/pull/25261
  • https://github.com/MetaMask/metamask-extension/pull/25125

georgewrmarshall avatar Jul 18 '24 20:07 georgewrmarshall

Builds ready [a19c80f]
Page Load Metrics (145 ± 170 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6911992147
domContentLoaded96226126
load401685145354170
domInteractive96226126

metamaskbot avatar Aug 16 '24 15:08 metamaskbot

Builds ready [141a07d]
Page Load Metrics (67 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6013195178
domContentLoaded96128157
load4611567199
domInteractive96028157

metamaskbot avatar Aug 20 '24 10:08 metamaskbot

Builds ready [23db62d]
Page Load Metrics (77 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint661411062010
domContentLoaded96729189
load51116772110
domInteractive96728189

metamaskbot avatar Aug 21 '24 19:08 metamaskbot

Codecov Report

Attention: Patch coverage is 48.30729% with 397 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (ef7fa43) to head (7848f3c).

Files with missing lines Patch % Lines
app/scripts/metamask-controller.js 30.59% 118 Missing :warning:
app/scripts/lib/setupSentry.js 14.81% 92 Missing :warning:
app/scripts/background.js 0.00% 90 Missing :warning:
app/scripts/controllers/swaps.ts 68.18% 63 Missing :warning:
app/scripts/ui.js 0.00% 13 Missing :warning:
app/scripts/lib/sentry-filter-events.ts 11.11% 8 Missing :warning:
app/scripts/controllers/swaps.utils.ts 90.00% 4 Missing :warning:
app/scripts/lib/accounts/BalancesController.ts 94.12% 2 Missing :warning:
app/scripts/lib/accounts/Poller.ts 84.62% 2 Missing :warning:
app/scripts/skip-onboarding.js 0.00% 2 Missing :warning:
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #25586      +/-   ##
==========================================
+ Coverage   65.73%   69.80%   +4.07%     
==========================================
  Files        1372     1370       -2     
  Lines       54777    48739    -6038     
  Branches    14270    13438     -832     
==========================================
- Hits        36006    34019    -1987     
+ Misses      18771    14720    -4051

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 11:08 codecov[bot]

Builds ready [23651ad]
Page Load Metrics (200 ± 269 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint761621002110
domContentLoaded106726147
load442644200561269
domInteractive106726147

metamaskbot avatar Aug 22 '24 12:08 metamaskbot

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/[email protected] network 0 3.36 MB blockaiduser
npm/@floating-ui/[email protected] environment 0 704 kB atomiks
npm/@floating-ui/[email protected] None 0 72.7 kB atomiks
npm/@json-schema-spec/[email protected] None 0 11.6 kB ucarion
npm/@json-schema-tools/[email protected] None 0 30.4 kB belfordz
npm/@json-schema-tools/[email protected] None 0 31.9 kB belfordz
npm/@json-schema-tools/[email protected] filesystem 0 42 kB belfordz
npm/@json-schema-tools/[email protected] None 0 26.4 kB belfordz
npm/@kurkle/[email protected] None 0 79.2 kB kurkle
npm/@mantine/[email protected] None 0 10.3 MB rtivital
npm/@mantine/[email protected] environment, network 0 1.02 MB rtivital
npm/@metamask-institutional/[email protected] None 0 33.1 kB aregadas
npm/@metamask/[email protected] None 0 305 kB metamaskbot
npm/@metamask/[email protected] None 0 193 kB metamaskbot
npm/@metamask/[email protected] None 0 228 kB metamaskbot
npm/@metamask/[email protected] None 0 289 kB metamaskbot
npm/@metamask/[email protected] None 0 227 kB metamaskbot
npm/@metamask/[email protected] None 0 163 kB metamaskbot
npm/@metamask/[email protected] None 0 245 kB metamaskbot
npm/@metamask/[email protected] None 0 78.5 kB metamaskbot
npm/@metamask/[email protected] None 0 786 kB metamaskbot
npm/@metamask/[email protected] None 0 118 kB metamaskbot
npm/@metamask/[email protected] None 0 155 kB metamaskbot
npm/@metamask/[email protected] None 0 240 kB metamaskbot
npm/@metamask/[email protected] None 0 1.3 MB metamaskbot
npm/@metamask/[email protected] None 0 5.46 MB metamaskbot
npm/@metamask/[email protected] None 0 922 kB metamaskbot
npm/@metamask/[email protected] network 0 781 kB metamaskbot
npm/@open-rpc/[email protected] None 0 57.7 kB belfordz
npm/@open-rpc/[email protected] None 0 2.07 MB shanejonas
npm/@open-rpc/[email protected] None 0 50.6 kB belfordz
npm/@open-rpc/[email protected] None 0 37.3 kB belfordz
npm/@open-rpc/[email protected] filesystem 0 86.3 kB belfordz
npm/@open-rpc/[email protected] network 0 44.6 kB belfordz
npm/@open-rpc/[email protected] filesystem, shell 0 94.9 kB belfordz
npm/@sentry-internal/[email protected] network 0 663 kB sentry-bot
npm/@sentry-internal/[email protected] None 0 555 kB sentry-bot
npm/@sentry-internal/[email protected] None 0 531 kB sentry-bot
npm/@sentry-internal/[email protected] None 0 3.73 MB sentry-bot
npm/@sentry/[email protected] network 0 956 kB sentry-bot
npm/@sentry/[email protected] network 0 1.89 MB sentry-bot
npm/@sentry/[email protected] None 0 329 kB sentry-bot
npm/@sentry/[email protected] network 0 1.14 MB sentry-bot
npm/@tabler/[email protected] None 0 35.1 MB codecalm
npm/@tabler/[email protected] None 0 8.62 MB codecalm
npm/@types/[email protected] None 0 2.74 kB types
npm/@types/[email protected] None 0 862 kB types
npm/@types/[email protected] None 0 120 kB types
npm/@typescript-eslint/[email protected] None 0 2.69 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 18 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 613 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 109 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 332 kB jameshenry
npm/[email protected] None 0 2.63 kB ryanzim
npm/[email protected] None 0 3.79 kB limulus
npm/[email protected] None 0 4.93 MB chartjs-ci
npm/[email protected] environment 0 39.5 kB dabh
npm/[email protected] None 0 13.1 kB riaevangelist
npm/[email protected] None 0 21.8 kB riaevangelist
npm/[email protected] None 0 7.12 kB tmpfs
npm/[email protected] None 0 6.34 kB mattandrews
npm/[email protected] None 0 9.22 kB riaevangelist
npm/[email protected] None 0 13.1 kB riaevangelist
npm/[email protected] environment 0 1.3 MB pateketrueke
npm/[email protected] filesystem, network 0 2 MB jamesmessinger
npm/[email protected] unsafe 0 301 kB brettz9
npm/[email protected] None 0 26.4 kB developit
npm/[email protected] filesystem, network 0 130 kB riaevangelist
npm/[email protected] None 0 65.2 kB bigstickcarpet
npm/[email protected] None 0 56.9 kB dangreen
npm/[email protected] None 0 253 kB sudhanshu
npm/[email protected] None 0 25 kB kashey
npm/[email protected] None 0 79 kB kashey
npm/[email protected] None 0 57.9 kB react-textarea-autosize-release-bot
npm/[email protected] eval 0 402 kB yysuni
npm/[email protected] None 0 14.5 kB lukeed
npm/[email protected] None 0 412 kB stefcameron
npm/[email protected] None 0 3.06 kB andarist
npm/[email protected] environment 0 4.24 kB andarist
npm/[email protected] environment 0 38 kB gnoff
npm/[email protected] network 0 57.4 kB jakechampion
npm/[email protected] None 0 61.1 kB molefrog

🚮 Removed packages: npm/@blockaid/[email protected]), npm/@floating-ui/[email protected]), npm/@metamask-institutional/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@metamask/[email protected]), npm/@sentry-internal/[email protected]), npm/@sentry/[email protected]), npm/@sentry/[email protected]), npm/@sentry/[email protected]), npm/@sentry/[email protected]), npm/@sentry/[email protected]), npm/@sentry/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected])

View full report↗︎

socket-security[bot] avatar Aug 22 '24 13:08 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@mantine/[email protected], npm/@metamask/[email protected], npm/@open-rpc/[email protected], npm/@open-rpc/[email protected], npm/@sentry-internal/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar Aug 22 '24 13:08 socket-security[bot]

Builds ready [b7db14f]
Page Load Metrics (176 ± 192 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint823061226330
domContentLoaded1098402211
load431907176400192
domInteractive1098402211

metamaskbot avatar Aug 22 '24 13:08 metamaskbot

@SocketSecurity ignore npm/@metamask/[email protected]

This is our package

Gudahtt avatar Aug 22 '24 14:08 Gudahtt

@SocketSecurity ignore npm/@open-rpc/[email protected] @SocketSecurity ignore npm/[email protected]

These packages are intended to have network access

Gudahtt avatar Aug 22 '24 14:08 Gudahtt

@SocketSecurity ignore npm/[email protected]

Network access is intended here as well, and the deprecation is not of immediate concern

Gudahtt avatar Aug 22 '24 14:08 Gudahtt

@SocketSecurity ignore npm/@open-rpc/[email protected]

Shell access OK, this is expected

Gudahtt avatar Aug 22 '24 14:08 Gudahtt

@SocketSecurity ignore npm/[email protected]

New author OK, also this version of the package is quite old and unlikely to have been a malicious takeover.

Gudahtt avatar Aug 22 '24 14:08 Gudahtt

@SocketSecurity ignore npm/[email protected] @SocketSecurity ignore npm/@mantine/[email protected]

Network access is expected in these cases as well

Gudahtt avatar Aug 22 '24 14:08 Gudahtt

Builds ready [04c5fc6]
Page Load Metrics (68 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint602961025426
domContentLoaded994252110
load38206683919
domInteractive994252110

metamaskbot avatar Aug 22 '24 20:08 metamaskbot

Builds ready [6927746]
Page Load Metrics (147 ± 171 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint662731034723
domContentLoaded97526189
load421700147357171
domInteractive97526189

metamaskbot avatar Aug 22 '24 20:08 metamaskbot

@SocketSecurity ignore npm/@sentry-internal/[email protected] @SocketSecurity ignore npm/@sentry/[email protected] @SocketSecurity ignore npm/@sentry/[email protected]

These are expected to have network access

Gudahtt avatar Aug 22 '24 21:08 Gudahtt

Builds ready [42555d3]
Page Load Metrics (181 ± 226 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint631501032412
domContentLoaded97831188
load402230181471226
domInteractive97831188

metamaskbot avatar Aug 22 '24 21:08 metamaskbot

I tested the recent three Sentry commits by generally following the instructions here: https://github.com/MetaMask/metamask-extension/pull/26605/

The one adjustment I made was to set the sample rate to 1 so that performance events would be guaranteed to be sent. That can be adjusted here: https://github.com/MetaMask/metamask-extension/blob/42555d383bbfe9214941f84dd11733bca92e668c/app/scripts/lib/setupSentry.js#L85

I was able to confirm that:

  • Errors were received from both mv3 and mv2 builds, and source maps are working correctly (Sentry showed unminified stack traces)
  • We are receiving performance data, including page load time.

Gudahtt avatar Aug 22 '24 22:08 Gudahtt

Builds ready [5bdc48e]
Page Load Metrics (137 ± 160 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61287934723
domContentLoaded98119168
load401581137333160
domInteractive98119167

metamaskbot avatar Aug 23 '24 00:08 metamaskbot