Daniel Galvez

Results 85 comments of Daniel Galvez

Resolved the previous messages from @titu1994 without responding since this isn't a good approach. Force pushed a simple commit reverting #4277 for now. More details in #4455. Note: This is...

> this PR does not contain the code to prepare the WFST 'adaptation graphs', Is it a good idea to merge this PR as is without an example WFST that...

Openfst is a C++17 library as of 1.8.0. Since it's a template library, C++17-isms will probably leak into the kaldi source code, so we should probably migrate to C++17 at...

I have personally enjoyed using CMake quite a lot. It is a fairly involved build system to set up, but it is also easiest to extend in an already existing...

I would also like to mention that I personally like how cmakemakes installing dependencies, really, really easy. For example, even though wav2letter and flashlight have a nightmarish number of dependencies,...

@danpovey I will volunteer for it. I have the experience it takes. I'm not entirely sure about all of the work involved, but I hope to essentially eradicate the tools...

I see. What I like about CMake is that you can add external projects, even those that don't use cmake, like openfst. You can dig around in this file to...

@DMats Hi, I haven't met you before, but thank you for recommending that book! I wasn't aware that an authoritative book had actually been written on cmake. I had picked...

I've been writing up a list of nice things that cmake will give us. They are: - Easy ARM Cross-compilation and simulation (You can run the tests in an ARM...

> Do you see any downsides? There are unfortunately a lot of downsides to your proposal. As Dan mentions, > BTW, I seem to remember that stdlib containers are not...