WIP Fix for #4455

[galv]

What does this PR do ?

Proposed fix for #4455

Collection: asr, common

Changelog

• Plumb is_tar_manifest throughout dataset code.
• Fix for KeyError.

Usage

This allow for running ASR training on tar files with keys containing "/".

is_tar_manifest needs to be plumbed through all possible parse_func's in usage today.

Before your PR is "Ready for review"

Pre checks:

• [ ] Make sure you read and followed Contributor guidelines
• [ ] Did you write any new necessary tests?
• [ ] Did you add or update any necessary documentation?
• [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

• [X] New Feature
• [ ] Bugfix
• [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

• Related to #4455

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 653d4d755d0132d640305017336ddbf612705aeb into d8785e022e2ccaf8b02a27ca084aea5acd257b18 - view on LGTM.com

new alerts:

• 1 for Wrong number of arguments in a call

[galv]

Resolved the previous messages from @titu1994 without responding since this isn't a good approach.

Force pushed a simple commit reverting #4277 for now. More details in #4455.

Note: This is my first PR. I signed the commit, not sure if there's anything else I ought to do (e.g., to restart CI).

[titu1994]

Steve added some changes to main branch, could you try rebasing this PR with main, and then try out if his fixes were sufficient ? If not we may need further changes.

[titu1994]

For DCO, ignore it for now.

[stevehuang52]

The problem was already fixed in this PR, closing this PR