Sebastian Gaida
Sebastian Gaida
Hey, @danrbailey since you were involved in #612 I wanted to ask if this PR is correct or what should be changed. I shortened the paths like you suggested, from...
I reverted the changes and the build failed. The problem was, that includes from other cmake files/executables did not find shortend paths like `#include "openvdb.h"` instead they need a `#include...
I looked it all through and resolved all the issues you had. Also changed the `#include ` to `#include "openvdb/version.h"`.
Sure, if you have no other suggestions.
I've made the suggested change that @e4lam pointed out (in `openvdb/Exceptions.h`). But I'll set the PR back to draft, until the discussion is resolved.
@danrbailey pointed out that these changes with `"../"` should not be made, because of the style-guide mentioned [here](https://github.com/AcademySoftwareFoundation/openvdb/pull/1300#pullrequestreview-882409366). I could revert the changes, where the correct relative path would include...
>> I've made the suggested change that @e4lam pointed out (in openvdb/Exceptions.h). But I'll set the PR back to draft, until the discussion is resolved. >You may find that simply...
This issue should have been resolved with #1418.
Sorry for the ping, but would be great, if you could run the CI and maybe take a look. (you took a look at the previous PR https://github.com/AcademySoftwareFoundation/openvdb/pull/1363) @jmlait @Idclip...